r101618 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101617‎ | r101618 | r101619 >
Date:11:34, 2 November 2011
Author:catrope
Status:resolved
Tags:
Comment:
Followup r101548: build the link in a less scary way, with proper escaping
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -44,6 +44,10 @@
4545 $button.append( '<div class="mw-wikilove-r-cap"></div>');
4646 $typeList.append( $( '<li tabindex="0"></li>' ).append( $button ) );
4747 }
 48+
 49+ var $termsLink = $( '<a> ')
 50+ .attr( 'href', mw.msg( 'wikilove-commons-url' ) )
 51+ .text( mw.msg( 'wikilove-commons-link' ) );
4852
4953 $dialog = $( '\
5054 <div id="mw-wikilove-dialog">\
@@ -92,7 +96,7 @@
9397 <span class="mw-wikilove-note" id="mw-wikilove-image-note"><html:msg key="wikilove-image-example"/></span>\
9498 <input type="text" class="text" id="mw-wikilove-image"/>\
9599 <div id="mw-wikilove-commons-text">\
96 - ' + mw.msg( 'wikilove-commons-text', '<a href="' + mw.msg( 'wikilove-commons-url' ) + '" target="_blank">' + mw.msg( 'wikilove-commons-link' ) +'</a>' ) + '\
 100+ ' + mw.msg( 'wikilove-commons-text', $termsLink.html() ) + '\
97101 </div>\
98102 <label for="mw-wikilove-message" id="mw-wikilove-message-label"><html:msg key="wikilove-enter-message"/></label>\
99103 <span class="mw-wikilove-note" id="mw-wikilove-message-note"><html:msg key="wikilove-omit-sig"/></span>\

Follow-up revisions

RevisionCommit summaryAuthorDate
r101620Followup r101618: actually make things work. You can't feed HTML to mw.msg() ...catrope12:34, 2 November 2011
r101621Followup r101618, r101620: forgot target="_blank"catrope12:36, 2 November 2011
r1016601.18wmf1: Merge stuff for editor engagement deployment...catrope19:01, 2 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101548legal terms update for WikiLove, part deuxkaldari23:00, 1 November 2011

Status & tagging log