r101621 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101620‎ | r101621 | r101622 >
Date:12:36, 2 November 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r101618, r101620: forgot target="_blank"
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js
@@ -47,12 +47,14 @@
4848
4949 var commonsLink = $( '<a>' )
5050 .attr( 'href', mw.msg( 'wikilove-commons-url' ) )
 51+ .attr( 'target', '_blank' )
5152 .text( mw.msg( 'wikilove-commons-link' ) )
5253 .wrap( '<div>' ) // or .html() will only return the link text
5354 .parent()
5455 .html();
5556 termsLink = $( '<a> ')
5657 .attr( 'href', mw.msg( 'wikilove-terms-url' ) )
 58+ .attr( 'target', '_blank' )
5759 .text( mw.msg( 'wikilove-terms-link' ) )
5860 .wrap( '<div>' )
5961 .parent()

Follow-up revisions

RevisionCommit summaryAuthorDate
r1016601.18wmf1: Merge stuff for editor engagement deployment...catrope19:01, 2 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101618Followup r101548: build the link in a less scary way, with proper escapingcatrope11:34, 2 November 2011
r101620Followup r101618: actually make things work. You can't feed HTML to mw.msg() ...catrope12:34, 2 November 2011

Status & tagging log