r101617 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101616‎ | r101617 | r101618 >
Date:11:31, 2 November 2011
Author:catrope
Status:ok
Tags:aft 
Comment:
Followup r101611, move the privacy policy URL back into a message. Kaldari makes a good point about translated versions
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php
@@ -36,7 +36,8 @@
3737 'articlefeedback-survey-message-success',
3838 'articlefeedback-survey-message-error',
3939 'articlefeedback-survey-disclaimer',
40 - 'articlefeedback-survey-disclaimerlink'
 40+ 'articlefeedback-survey-disclaimerlink',
 41+ 'articlefeedback-privacyurl'
4142 ),
4243 'dependencies' => array(
4344 'jquery.ui.dialog',
@@ -83,7 +84,7 @@
8485 'articlefeedback-report-panel-description',
8586 'articlefeedback-report-empty',
8687 'articlefeedback-report-ratings',
87 - 'parentheses',
 88+ 'articlefeedback-privacyurl'
8889 ),
8990 'dependencies' => array(
9091 'jquery.appear',
@@ -279,8 +280,7 @@
280281 $wgArticleFeedbackTracking,
281282 $wgArticleFeedbackOptions,
282283 $wgArticleFeedbackNamespaces,
283 - $wgArticleFeedbackRatingTypes,
284 - $wgArticleFeedbackPrivacyURL;
 284+ $wgArticleFeedbackRatingTypes;
285285 $vars['wgArticleFeedbackSMaxage'] = $wgArticleFeedbackSMaxage;
286286 $vars['wgArticleFeedbackCategories'] = $wgArticleFeedbackCategories;
287287 $vars['wgArticleFeedbackBlacklistCategories'] = $wgArticleFeedbackBlacklistCategories;
@@ -290,7 +290,6 @@
291291 $vars['wgArticleFeedbackNamespaces'] = $wgArticleFeedbackNamespaces;
292292 $vars['wgArticleFeedbackWhatsThisPage'] = wfMsgForContent( 'articlefeedback-form-panel-explanation-link' );
293293 $vars['wgArticleFeedbackRatingTypesFlipped'] = array_flip( $wgArticleFeedbackRatingTypes );
294 - $vars['wgArticleFeedbackPrivacyURL'] = $wgArticleFeedbackPrivacyURL;
295294 return true;
296295 }
297296
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -595,7 +595,7 @@
596596 .html( function() {
597597 var link = mw.html.element(
598598 'a', {
599 - href: context.options.privacyURL
 599+ href: mw.msg( 'articlefeedback-privacyurl' )
600600 }, mw.msg( 'articlefeedback-form-panel-helpimprove-privacy' )
601601 );
602602 return mw.html.escape( mw.msg( 'articlefeedback-form-panel-helpimprove-note' ) )
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -124,7 +124,7 @@
125125 .html( function() {
126126 var link = mw.html.element(
127127 'a', {
128 - href: mw.config.get( 'wgArticleFeedbackPrivacyURL' )
 128+ href: mw.msg( 'articlefeedback-privacyurl' )
129129 }, mw.msg( 'articlefeedback-survey-disclaimerlink' )
130130 );
131131 return mw.html.escape( mw.msg( 'articlefeedback-survey-disclaimer' ) )
@@ -312,8 +312,7 @@
313313 'accept': 'articlefeedback-pitch-edit-accept',
314314 'reject': 'articlefeedback-pitch-reject'
315315 }
316 - },
317 - 'privacyURL': mw.config.get( 'wgArticleFeedbackPrivacyURL' )
 316+ }
318317 };
319318
320319 /* Load at the bottom of the article */
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -98,6 +98,7 @@
9999 'articlefeedback-survey-message-success' => 'Thanks for filling out the survey.',
100100 'articlefeedback-survey-message-error' => 'An error has occurred.
101101 Please try again later.',
 102+ 'articlefeedback-privacyurl' => 'http://wikimediafoundation.org/wiki/Feedback_privacy_statement',
102103 /* Special:ArticleFeedback */
103104 'articleFeedback-table-caption-dailyhighsandlows' => 'Today\'s highs and lows',
104105 'articleFeedback-table-caption-dailyhighs' => 'Pages with highest ratings: $1',
@@ -187,6 +188,7 @@
188189 'articlefeedback-pitch-join-body' => 'Based on {{msg-mw|Articlefeedback-pitch-join-message}}.',
189190 'articlefeedback-pitch-join-accept' => '{{Identical|Create an account}}',
190191 'articlefeedback-pitch-join-login' => '{{Identical|Log in}}',
 192+ 'articlefeedback-privacyurl' => 'This URL can be changed to point to a translated version of the page if it exists.',
191193 'articleFeedback-table-heading-page' => 'This is used in the [[mw:Extension:ArticleFeedback|Article Feedback extension]].
192194 {{Identical|Page}}',
193195 'articleFeedback-table-heading-average' => '{{Identical|Average}}',
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.php
@@ -88,11 +88,6 @@
8989 */
9090 $wgArticleFeedbackDashboardTalkPage = "http://www.mediawiki.org/wiki/Talk:Article_feedback";
9191
92 -/**
93 - * The full URL for the privacy policy links
94 - */
95 -$wgArticleFeedbackPrivacyURL = 'http://wikimediafoundation.org/wiki/Feedback_privacy_statement';
96 -
9792 // Would ordinarily call this articlefeedback but survey names are 16 chars max
9893 $wgPrefSwitchSurveys['articlerating'] = array(
9994 'updatable' => false,

Sign-offs

UserFlagDate
Nikerabbitinspected14:00, 2 November 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r1016601.18wmf1: Merge stuff for editor engagement deployment...catrope19:01, 2 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101611Fix r101532 which was so broken that I refuse to believe it was tested even o...catrope10:54, 2 November 2011

Status & tagging log