r101801 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101800‎ | r101801 | r101802 >
Date:09:27, 3 November 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Per comments in r101477, changed all (not) null to (NOT) NULL for consistency.
Modified paths:
  • /trunk/extensions/Translate/sql/revtag.sql (modified) (history)
  • /trunk/extensions/Translate/sql/translate_groupreviews.sql (modified) (history)
  • /trunk/extensions/Translate/sql/translate_reviews.sql (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/sql/translate_reviews.sql
@@ -1,12 +1,12 @@
22 -- Translation reviews; to store reviews of a page revision by a user.
33 CREATE TABLE /*$wgDBprefix*/translate_reviews (
4 - trr_user int not null,
 4+ trr_user int NOT NULL,
55
66 -- Link to page.page_id
7 - trr_page int not null,
 7+ trr_page int NOT NULL,
88
99 -- Link to revision.rev_id
10 - trr_revision int not null
 10+ trr_revision int NOT NULL
1111 ) /*$wgDBTableOptions*/;
1212
1313 CREATE UNIQUE INDEX /*i*/trr_user_page_revision ON /*$wgDBprefix*/translate_reviews
Index: trunk/extensions/Translate/sql/revtag.sql
@@ -2,15 +2,15 @@
33
44 -- Revision tags
55 CREATE TABLE /*$wgDBprefix*/revtag (
6 - rt_type varbinary(60) not null,
 6+ rt_type varbinary(60) NOT NULL,
77
88 -- Link to page.page_id
9 - rt_page int not null,
 9+ rt_page int NOT NULL,
1010
1111 -- Link to revision.rev_id
12 - rt_revision int not null,
 12+ rt_revision int NOT NULL,
1313
14 - rt_value blob null
 14+ rt_value blob NULL
1515 ) /*$wgDBTableOptions*/;
1616 -- Index for finding all revisions in a page with a given tag
1717 CREATE UNIQUE INDEX /*i*/rt_type_page_revision ON /*$wgDBprefix*/revtag
Index: trunk/extensions/Translate/sql/translate_groupreviews.sql
@@ -7,7 +7,7 @@
88 tgr_group varchar(200) binary NOT NULL,
99 tgr_lang varchar(20) binary NOT NULL,
1010 -- Any of user configured values from $wgTranslateWorkflowStates
11 - tgr_state varbinary(32) not null,
 11+ tgr_state varbinary(32) NOT NULL,
1212
1313 PRIMARY KEY (tgr_group, tgr_lang)
1414 ) /*$wgDBTableOptions*/;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101477Table for message group states...nikerabbit14:10, 1 November 2011

Status & tagging log