r100923 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r100922‎ | r100923 | r100924 >
Date:00:51, 27 October 2011
Author:khorn
Status:ok
Tags:fundraising 
Comment:
Builds a minimal querystring with wfArrayToCGI() instead of manually with no escaping.
r97115
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
——@@ -727,7 +727,7 @@
728728 */
729729 protected function stage_returnto( $type = 'request' ) {
730730 if ( $type === 'request' ) {
731 - $this->postdata['returnto'] = $this->postdata['returnto'] . "?order_id=" . $this->postdata['order_id'];
 731+ $this->postdata['returnto'] = $this->postdata['returnto'] . '?' . wfArrayToCGI( array( 'order_id' => $this->postdata['order_id'] ) );
732732 }
733733 }
734734

Follow-up revisions

RevisionCommit summaryAuthorDate
r101857follow-up to r100923 and r97115 - better method for constructing URLkaldari19:12, 3 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97115Removing GC's ability to send credit card infokhorn23:43, 14 September 2011

Status & tagging log