r101857 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101856‎ | r101857 | r101858 >
Date:19:12, 3 November 2011
Author:kaldari
Status:deferred (Comments)
Tags:fundraising 
Comment:
follow-up to r100923 and r97115 - better method for constructing URL
Modified paths:
  • /trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php
@@ -804,7 +804,9 @@
805805 */
806806 protected function stage_returnto( $type = 'request' ) {
807807 if ( $type === 'request' ) {
808 - $this->postdata['returnto'] = $this->postdata['returnto'] . '?' . wfArrayToCGI( array( 'order_id' => $this->postdata['order_id'] ) );
 808+ // Add order ID to the returnto URL
 809+ $queryArray = array( 'order_id' => $this->postdata['order_id'] );
 810+ $this->postdata['returnto'] = wfAppendQuery( $this->postdata['returnto'], $queryArray );
809811 }
810812 }
811813

Follow-up revisions

RevisionCommit summaryAuthorDate
r102030Locks down all staged gateway data, and (hopefully) makes the distinction bet...khorn19:37, 4 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97115Removing GC's ability to send credit card infokhorn23:43, 14 September 2011
r100923Builds a minimal querystring with wfArrayToCGI() instead of manually with no ...khorn00:51, 27 October 2011

Comments

#Comment by Khorn (WMF) (talk | contribs)   19:27, 5 November 2011

This got changed later.

Status & tagging log