r100924 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100923‎ | r100924 | r100925 >
Date:00:59, 27 October 2011
Author:kaldari
Status:ok
Tags:fundraising 
Comment:
fixing webitects globalcollect form for IE7
Modified paths:
  • /trunk/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php (modified) (history)
  • /trunk/extensions/DonationInterface/gateway_forms/rapidhtml/css/Webitects.css (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects_2_3step.html (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/lightbox1.js (modified) (history)
  • /trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/gateway_forms/rapidhtml/RapidHtmlResources.php
@@ -6,6 +6,7 @@
77 */
88
99 $wgPayflowRapidHtmlRemoteExtPath = 'DonationInterface/gateway_forms/rapidhtml';
 10+$wgGlobalCollectRapidHtmlRemoteExtPath = 'DonationInterface/globalcollect_gateway/forms';
1011
1112 /**
1213 * LIGHTBOX
@@ -60,6 +61,16 @@
6162 'localBasePath' => dirname( __FILE__ ),
6263 'remoteExtPath' => $wgPayflowRapidHtmlRemoteExtPath,
6364 );
 65+$wgResourceModules[ 'gc.form.rapidhtml.webitects_2_3step' ] = array(
 66+ 'scripts' => array(
 67+ 'js/webitects_2_3step.js',
 68+ ),
 69+ 'dependencies' => array(
 70+ 'pfp.form.rapidhtml.webitects'
 71+ ),
 72+ 'localBasePath' => dirname( __FILE__ ).'/../../globalcollect_gateway/forms',
 73+ 'remoteExtPath' => $wgGlobalCollectRapidHtmlRemoteExtPath,
 74+);
6475
6576 /**
6677 * globalcollect_test
Index: trunk/extensions/DonationInterface/gateway_forms/rapidhtml/css/Webitects.css
@@ -37,7 +37,7 @@
3838 /* Specifics
3939 ======================================================================*/
4040 /* Buttons */
41 -.btn { display: inline-block; padding: 0.3em 0.5em; vertical-align: middle; font-size: 12px; }
 41+.btn { display: inline-block; font-size: 12px; }
4242
4343 /* Donate options */
4444 .donate-options input { width: 15em; }
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/html/webitects_2_3step.html
@@ -1,7 +1,5 @@
22 <script type="text/javascript">
3 - mw.loader.load('pfp.form.rapidhtml.webitects');
4 - var extensionPath = mw.config.get( 'wgServer' ) + mw.config.get( 'wgScriptPath' ) + '/extensions/DonationInterface';
5 - mw.loader.load( extensionPath + '/globalcollect_gateway/forms/js/webitects_2_3step.js', 'text/javascript' );
 3+ mw.loader.load('gc.form.rapidhtml.webitects_2_3step');
64 // these must go through RapidHTML and thus are inline
75 var amountErrors = ['#general|escape','#retryMsg|escape','#amount|escape'],
86 billingErrors = ['#fname|escape','#lname|escape','#city|escape','#country|escape',
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/webitects_2_3step.js
@@ -121,7 +121,7 @@
122122 setAmount( $( this ) );
123123 } );
124124 // reset the amount field when "other" is changed
125 - $( "#other-amount" ).change( function() {
 125+ $( "#other-amount" ).keyup( function() {
126126 setAmount( $( this ) );
127127 } );
128128
@@ -291,4 +291,4 @@
292292 error = true;
293293 }
294294 return !error;
295 -}
\ No newline at end of file
 295+}
Index: trunk/extensions/DonationInterface/globalcollect_gateway/forms/js/lightbox1.js
@@ -23,7 +23,7 @@
2424
2525 /* Set selected amount to amount */
2626 $( "input[name='amountRadio']" ).click( function() { setAmount( $( this ) ); } );
27 - $( "#other-amount" ).change( function() { setAmount( $( this ) ); } );
 27+ $( "#other-amount" ).keyup( function() { setAmount( $( this ) ); } );
2828 function setAmount(e) { $("input[name='amount']").val( e.val() ); }
2929
3030 /* number of fieldsets */

Status & tagging log