r100437 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100436‎ | r100437 | r100438 >
Date:18:53, 21 October 2011
Author:reedy
Status:resolved
Tags:
Comment:
Followup r100436, put the code in the right place
Modified paths:
  • /trunk/extensions/Contest/resources/contest.special.editcontest.js (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialContestWelcome.php (modified) (history)
  • /trunk/extensions/Contest/specials/SpecialEditContest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/specials/SpecialContestWelcome.php
@@ -142,13 +142,11 @@
143143 $challenges[] = $data;
144144 }
145145
146 - global $wgContestDeletionEnabled;
147 - $this->getOutput()->addScript(
 146+ $output->addScript(
148147 Skin::makeVariablesScript(
149148 array(
150149 'ContestChallenges' => $challenges,
151150 'ContestConfig' => array(),
152 - 'ContestDeletionEnabled' => $wgContestDeletionEnabled,
153151 )
154152 )
155153 );
Index: trunk/extensions/Contest/specials/SpecialEditContest.php
@@ -95,6 +95,14 @@
9696 protected function showContent( $subPage ) {
9797 $isNew = $this->getRequest()->wasPosted() && $this->getUser()->matchEditToken( $this->getRequest()->getVal( 'newEditToken' ) );
9898
 99+ global $wgContestDeletionEnabled;
 100+ $this->getOutput()->addScript(
 101+ Skin::makeVariablesScript(
 102+ array(
 103+ 'ContestDeletionEnabled' => $wgContestDeletionEnabled,
 104+ )
 105+ )
 106+ );
99107 if ( $isNew ) {
100108 $data = array( 'name' => $this->getRequest()->getVal( 'newcontest' ) );
101109
Index: trunk/extensions/Contest/resources/contest.special.editcontest.js
@@ -89,9 +89,8 @@
9090 return false;
9191 }
9292 } );
 93+ $this.append( this.deleteButton );
9394 }
94 -
95 - $this.append( this.deleteButton );
9695 };
9796
9897 this.init();

Follow-up revisions

RevisionCommit summaryAuthorDate
r100438follow up r100437 r100436jeroendedauw19:05, 21 October 2011
r1004401.18wmf1 REL r100402, r100405, r100419, r100427, r100432, r100433, r100435, r...reedy19:22, 21 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r100436Followup r100432...reedy18:47, 21 October 2011

Status & tagging log