r100435 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100434‎ | r100435 | r100436 >
Date:18:33, 21 October 2011
Author:jeroendedauw
Status:ok
Tags:
Comment:
just forget about clikable rows; turns out to be very hard and not nice to have this fully work as regular links
Modified paths:
  • /trunk/extensions/Contest/resources/contest.contestant.pager.css (modified) (history)
  • /trunk/extensions/Contest/resources/contest.contestant.pager.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Contest/resources/contest.contestant.pager.css
@@ -6,6 +6,6 @@
77 * @author Jeroen De Dauw <jeroendedauw at gmail dot com>
88 */
99
10 -.contestant-row td:hover {
 10+/*.contestant-row td:hover {
1111 cursor: pointer;
12 -}
\ No newline at end of file
 12+}*/
\ No newline at end of file
Index: trunk/extensions/Contest/resources/contest.contestant.pager.js
@@ -8,12 +8,15 @@
99
1010 (function( $, mw ) {
1111
12 - $( document ).ready( function() {
 12+// $( document ).ready( function() {
 13+//
 14+// $( '.contestant-row' ).click( function( e ) {
 15+// window.open(
 16+// $( this ).attr( 'data-contestant-target' ),
 17+// e.metaKey ? '_blank' : '_self'
 18+// );
 19+// } );
 20+//
 21+// } );
1322
14 - $( '.contestant-row' ).click( function() {
15 - window.location = $( this ).attr( 'data-contestant-target' );
16 - } );
17 -
18 - } );
19 -
2023 })( window.jQuery, window.mediaWiki );

Follow-up revisions

RevisionCommit summaryAuthorDate
r1004401.18wmf1 REL r100402, r100405, r100419, r100427, r100432, r100433, r100435, r...reedy19:22, 21 October 2011

Status & tagging log