r99309 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r99308
|
r99309
|
r99310
>
Date:
13:07, 8 October 2011
Author:
hartman
Status:
reverted (
Comments
)
Tags:
Comment:
Follow up to
r99307
, with some inline comment documentation on why these !important are used.
Modified paths:
/trunk/phase3/resources/jquery/jquery.tablesorter.css
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/resources/jquery/jquery.tablesorter.css
—
—
@@ -1,4 +1,8 @@
2
-/* Table Sorting */
2
+/*
3
+ * The !important is to make sure someone doesn't use element styling
4
+ * to set the background or padding of a headercell and
5
+ * accidently override all these options.
6
+ */
3
7
table.jquery-tablesorter th.headerSort {
4
8
/* @embed */
5
9
background-image: url(images/sort_both.gif) !important;
Follow-up revisions
Revision
Commit summary
Author
Date
r102452
Revert
r99307
and its friend
r99309
, improper use of !important per CR
catrope
21:38, 8 November 2011
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r99307
Add !important to the tablesorter indicator....
hartman
12:59, 8 October 2011
Comments
#
Comment by
Hashar
(
talk
|
contribs
)
09:25, 8 November 2011
tagging 1.18 we might as well add documentation :-)
Status & tagging log
21:38, 8 November 2011
Catrope
(
talk
|
contribs
)
changed the
status
of r99309
[
removed:
ok
added:
reverted]
21:17, 8 November 2011
Krinkle
(
talk
|
contribs
)
changed the
tags
for r99309
[
removed:
1.18]
09:25, 8 November 2011
Hashar
(
talk
|
contribs
)
changed the
tags
for r99309
[
added:
1.18]
09:25, 8 November 2011
Hashar
(
talk
|
contribs
)
changed the
status
of r99309
[
removed:
new
added:
ok]