r102452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102451‎ | r102452 | r102453 >
Date:21:38, 8 November 2011
Author:catrope
Status:ok
Tags:
Comment:
Revert r99307 and its friend r99309, improper use of !important per CR
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tablesorter.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tablesorter.css
@@ -1,21 +1,17 @@
2 -/*
3 - * The !important is to make sure someone doesn't use element styling
4 - * to set the background or padding of a headercell and
5 - * accidently override all these options.
6 - */
 2+/* Table Sorting */
73 table.jquery-tablesorter th.headerSort {
84 /* @embed */
9 - background-image: url(images/sort_both.gif) !important;
 5+ background-image: url(images/sort_both.gif);
106 cursor: pointer;
11 - background-repeat: no-repeat !important;
12 - background-position: center right !important;
13 - padding-right: 21px !important;
 7+ background-repeat: no-repeat;
 8+ background-position: center right;
 9+ padding-right: 21px;
1410 }
1511 table.jquery-tablesorter th.headerSortUp {
1612 /* @embed */
17 - background-image: url(images/sort_up.gif) !important;
 13+ background-image: url(images/sort_up.gif);
1814 }
1915 table.jquery-tablesorter th.headerSortDown {
2016 /* @embed */
21 - background-image: url(images/sort_down.gif) !important;
 17+ background-image: url(images/sort_down.gif);
2218 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99307Add !important to the tablesorter indicator....hartman12:59, 8 October 2011
r99309Follow up to r99307, with some inline comment documentation on why these !imp...hartman13:07, 8 October 2011

Status & tagging log