r99177 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99176‎ | r99177 | r99178 >
Date:00:58, 7 October 2011
Author:saper
Status:ok (Comments)
Tags:
Comment:
Followup to r99131: Provide mw-fr-comment-box id to hide the comment box.
Use CSS to move buttons to the right to facilitate nice hiding.
Modified paths:
  • /trunk/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/presentation/modules/flaggedrevs.css (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/presentation/RevisionReviewFormUI.php
@@ -180,10 +180,9 @@
181181 # Hide comment input if needed
182182 if ( !$disabled ) {
183183 $form .= Xml::inputLabel(
184 - wfMsg( 'revreview-log' ), 'wpReason', 'wpReason', 40, '',
185 - array( 'maxlength' => 255, 'id' => 'mw-fr-commentbox', 'class' => 'fr-comment-box' )
 184+ wfMsg( 'revreview-log' ), 'wpReason', 'mw-fr-comment-box', 40, '',
 185+ array( 'maxlength' => 255, 'class' => 'fr-comment-box' )
186186 );
187 - $form .= "   " . "\n";
188187 }
189188
190189 # Add the submit buttons...
Index: trunk/extensions/FlaggedRevs/presentation/modules/flaggedrevs.css
@@ -350,8 +350,8 @@
351351 margin: 0em 1em 0em .5em;
352352 }
353353
354 -.fr-comment-box {
355 - margin-top: .25em;
 354+#mw-fr-comment-box {
 355+ margin-right: 1.5em;
356356 }
357357
358358 .fr-rating-dave {

Follow-up revisions

RevisionCommit summaryAuthorDate
r99179Followup to r99177: Restore previous ID of the comment box nodesaper01:06, 7 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99131* Cleaned up "cancel" button on review form to only show on diffs...aaron19:57, 6 October 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   01:02, 7 October 2011

Nice...forgot to get rid of those.

Status & tagging log