r99176 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99175‎ | r99176 | r99177 >
Date:00:58, 7 October 2011
Author:kaldari
Status:ok
Tags:fundraising 
Comment:
more generic messaging, automatically constructed fundraising links dont neccessaily use LandingCheck
Modified paths:
  • /trunk/extensions/CentralNotice/CentralNotice.i18n.php (modified) (history)
  • /trunk/extensions/CentralNotice/special/SpecialNoticeTemplate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialNoticeTemplate.php
@@ -282,14 +282,14 @@
283283 // Checkbox for whether or not to use the LandingCheck extension
284284 $htmlOut .= Html::openElement( 'p', null );
285285 $htmlOut .= Xml::check( 'landingCheck', $landingCheck, array( 'id' => 'landingCheck' ) );
286 - $htmlOut .= Xml::label( wfMsg( 'centralnotice-banner-landingcheck' ), 'landingCheck' );
 286+ $htmlOut .= Xml::label( wfMsg( 'centralnotice-banner-autolink' ), 'landingCheck' );
287287 $htmlOut .= Html::closeElement( 'p' );
288288
289289 // Interface for setting the landing pages
290290 $htmlOut .= Html::openElement( 'div',
291291 array( 'id' => 'landingCheckInterface', 'style' => 'display: none;' ) );
292292 $htmlOut .= Xml::tags( 'p', array(),
293 - wfMsg( 'centralnotice-banner-landingcheck-help', 'id="cn-landingcheck-link"', 'JimmyAppeal01' ) );
 293+ wfMsg( 'centralnotice-banner-autolink-help', 'id="cn-landingpage-link"', 'JimmyAppeal01' ) );
294294 $htmlOut .= Xml::tags( 'p', array(),
295295 Xml::inputLabel(
296296 wfMsg( 'centralnotice-banner-landing-pages' ),
@@ -602,7 +602,7 @@
603603 $htmlOut .= Html::openElement( 'p', null );
604604 $htmlOut .= Xml::check( 'landingCheck', $landingCheck,
605605 wfArrayMerge( $disabled, array( 'id' => 'landingCheck' ) ) );
606 - $htmlOut .= Xml::label( wfMsg( 'centralnotice-banner-landingcheck' ),
 606+ $htmlOut .= Xml::label( wfMsg( 'centralnotice-banner-autolink' ),
607607 'landingCheck' );
608608 $htmlOut .= Html::closeElement( 'p' );
609609
@@ -614,7 +614,7 @@
615615 array( 'id'=>'landingCheckInterface', 'style'=>'display:none;' ) );
616616 }
617617 $htmlOut .= Xml::tags( 'p', array(),
618 - wfMsg( 'centralnotice-banner-landingcheck-help', 'id="cn-landingcheck-link"', 'JimmyAppeal01' ) );
 618+ wfMsg( 'centralnotice-banner-autolink-help', 'id="cn-landingpage-link"', 'JimmyAppeal01' ) );
619619 $htmlOut .= Xml::tags( 'p', array(),
620620 Xml::inputLabel(
621621 wfMsg( 'centralnotice-banner-landing-pages' ),
Index: trunk/extensions/CentralNotice/CentralNotice.i18n.php
@@ -132,8 +132,8 @@
133133 'centralnotice-banner-hidable' => 'Static/Hidable',
134134 'centralnotice-banner-collapsible' => 'Collapsible',
135135 'centralnotice-banner-fundraising' => 'This is a fundraising banner',
136 - 'centralnotice-banner-landingcheck' => 'Use LandingCheck extension',
137 - 'centralnotice-banner-landingcheck-help' => 'Create an anchor tag in the banner body with $1 and enter one or more landing pages below, for example, $2. The link will be constructed automatically.',
 136+ 'centralnotice-banner-autolink' => 'Automatically create landing page link',
 137+ 'centralnotice-banner-autolink-help' => 'Create an anchor tag in the banner body with $1 and enter one or more landing pages below, for example, $2. The link will be constructed automatically.',
138138 'centralnotice-banner-landing-pages' => 'Landing pages (comma-separated):',
139139 'centralnotice-geo' => 'Geotargeted',
140140 'centralnotice-countries' => 'Countries',
@@ -260,8 +260,7 @@
261261 'centralnotice-expand-button' => 'This is an action, a verb in imperative form. It refers to "Do expand the centralnotice!"
262262
263263 See also {{msg|Centralnotice-hide-button}}.',
264 - 'centralnotice-banner-landingcheck' => 'LandingCheck is the name of a MediaWiki extension.',
265 - 'centralnotice-banner-landingcheck-help' => 'An explanation for how to use the LandingCheck feature. $1 is a bit of HTML, $2 is a title for a page.',
 264+ 'centralnotice-banner-autolink-help' => 'Brief instructions on how to use the interface. $1 is a bit of HTML, $2 is a title for a page.',
266265 'centralnotice-geo' => 'Used to label a checkbox which activates geotargeting',
267266 'centralnotice-allocation' => 'Tab for sub-page [[m:BannerAllocation|banner allocation]] to central notice special page.',
268267 'centralnotice-view-allocation' => 'Heading of dialog box on [[m:Special:BannerAllocation|banner allocation]] special page.',

Follow-up revisions

RevisionCommit summaryAuthorDate
r99178follow-up to r99176 - forgot to update the js that generates the linkkaldari01:03, 7 October 2011
r100100MFT r92510, r92676, r96496, r97304, r99160, r99165, r99169, r99176, r99178, r...awjrichards23:56, 17 October 2011
r100102picking up i18n changes; MFT r99033, r99145, r99160, r99166, r99176, r99181, ...awjrichards00:03, 18 October 2011

Status & tagging log