r99072 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99071‎ | r99072 | r99073 >
Date:01:39, 6 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix PHP Fatal error: Class SkinTomas contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Skin::setupSkinUserCss) in /usr/local/apache/common-local/php-1.18/extensions/skins/Tomas/Tomas.class.php on line 51

and friends
Modified paths:
  • /trunk/extensions/skins/Donate/Donate.class.php (modified) (history)
  • /trunk/extensions/skins/Schulenburg/Schulenburg.class.php (modified) (history)
  • /trunk/extensions/skins/Tomas/Tomas.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/skins/Schulenburg/Schulenburg.class.php
@@ -41,7 +41,7 @@
4242 padding: 0px;
4343 background-image:url(<?php echo htmlspecialchars( "{$this->path}/images/background.gif" ) ; ?> ); background-repeat:repeat-y;
4444 background-position:center;
45 - background-color:#006699;
 45+ background-color:#006699;
4646 font-family: Verdana, Arial, Sans-Serif;
4747 font-size: 10pt;
4848 }
@@ -57,5 +57,17 @@
5858
5959 <?php
6060 }
 61+
 62+ /**
 63+ * Add skin specific stylesheets
 64+ * Calling this method with an $out of anything but the same OutputPage
 65+ * inside ->getOutput() is deprecated. The $out arg is kept
 66+ * for compatibility purposes with skins.
 67+ * @param $out OutputPage
 68+ * @delete
 69+ */
 70+ function setupSkinUserCss(OutputPage $out) {
 71+ // TODO: Implement setupSkinUserCss() method.
 72+ }
6173 }
6274
Index: trunk/extensions/skins/Tomas/Tomas.class.php
@@ -35,12 +35,12 @@
3636 <script type="text/javascript" src="<?php echo htmlspecialchars( $this->getMainJs() ); ?>"></script>
3737 <link rel="stylesheet" href="<?php echo htmlspecialchars( $siteCss ); ?>" type="text/css"/>
3838 <script type="text/javascript" src="<?php echo htmlspecialchars( $siteJs ); ?>"></script>
39 -
 39+
4040 </head>
4141
4242 <body>
4343 <div align="center">
44 -
 44+
4545 <?php echo $bodyText ?>
4646 </div>
4747 </body>
@@ -48,5 +48,17 @@
4949
5050 <?php
5151 }
 52+
 53+ /**
 54+ * Add skin specific stylesheets
 55+ * Calling this method with an $out of anything but the same OutputPage
 56+ * inside ->getOutput() is deprecated. The $out arg is kept
 57+ * for compatibility purposes with skins.
 58+ * @param $out OutputPage
 59+ * @delete
 60+ */
 61+ function setupSkinUserCss(OutputPage $out) {
 62+ // TODO: Implement setupSkinUserCss() method.
 63+ }
5264 }
5365
Index: trunk/extensions/skins/Donate/Donate.class.php
@@ -35,12 +35,12 @@
3636 <script type="text/javascript" src="<?php echo htmlspecialchars( $this->getMainJs() ); ?>"></script>
3737 <link rel="stylesheet" href="<?php echo htmlspecialchars( $siteCss ); ?>" type="text/css"/>
3838 <script type="text/javascript" src="<?php echo htmlspecialchars( $siteJs ); ?>"></script>
39 -
 39+
4040 </head>
4141
4242 <body>
4343 <div align="center">
44 -
 44+
4545 <?php echo $bodyText ?>
4646 </div>
4747 </body>
@@ -48,5 +48,17 @@
4949
5050 <?php
5151 }
 52+
 53+ /**
 54+ * Add skin specific stylesheets
 55+ * Calling this method with an $out of anything but the same OutputPage
 56+ * inside ->getOutput() is deprecated. The $out arg is kept
 57+ * for compatibility purposes with skins.
 58+ * @param $out OutputPage
 59+ * @delete
 60+ */
 61+ function setupSkinUserCss(OutputPage $out) {
 62+ // TODO: Implement setupSkinUserCss() method.
 63+ }
5264 }
5365

Follow-up revisions

RevisionCommit summaryAuthorDate
r99073MFT r99072reedy01:41, 6 October 2011

Status & tagging log