r99073 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99072‎ | r99073 | r99074 >
Date:01:41, 6 October 2011
Author:reedy
Status:ok
Tags:
Comment:
MFT r99072
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/skins (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/skins/Donate/Donate.class.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/skins/Schulenburg/Schulenburg.class.php (modified) (history)
  • /branches/wmf/1.18wmf1/extensions/skins/Tomas/Tomas.class.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/skins/Schulenburg/Schulenburg.class.php
@@ -41,7 +41,7 @@
4242 padding: 0px;
4343 background-image:url(<?php echo htmlspecialchars( "{$this->path}/images/background.gif" ) ; ?> ); background-repeat:repeat-y;
4444 background-position:center;
45 - background-color:#006699;
 45+ background-color:#006699;
4646 font-family: Verdana, Arial, Sans-Serif;
4747 font-size: 10pt;
4848 }
@@ -57,5 +57,17 @@
5858
5959 <?php
6060 }
 61+
 62+ /**
 63+ * Add skin specific stylesheets
 64+ * Calling this method with an $out of anything but the same OutputPage
 65+ * inside ->getOutput() is deprecated. The $out arg is kept
 66+ * for compatibility purposes with skins.
 67+ * @param $out OutputPage
 68+ * @delete
 69+ */
 70+ function setupSkinUserCss(OutputPage $out) {
 71+ // TODO: Implement setupSkinUserCss() method.
 72+ }
6173 }
6274
Index: branches/wmf/1.18wmf1/extensions/skins/Tomas/Tomas.class.php
@@ -35,12 +35,12 @@
3636 <script type="text/javascript" src="<?php echo htmlspecialchars( $this->getMainJs() ); ?>"></script>
3737 <link rel="stylesheet" href="<?php echo htmlspecialchars( $siteCss ); ?>" type="text/css"/>
3838 <script type="text/javascript" src="<?php echo htmlspecialchars( $siteJs ); ?>"></script>
39 -
 39+
4040 </head>
4141
4242 <body>
4343 <div align="center">
44 -
 44+
4545 <?php echo $bodyText ?>
4646 </div>
4747 </body>
@@ -48,5 +48,17 @@
4949
5050 <?php
5151 }
 52+
 53+ /**
 54+ * Add skin specific stylesheets
 55+ * Calling this method with an $out of anything but the same OutputPage
 56+ * inside ->getOutput() is deprecated. The $out arg is kept
 57+ * for compatibility purposes with skins.
 58+ * @param $out OutputPage
 59+ * @delete
 60+ */
 61+ function setupSkinUserCss(OutputPage $out) {
 62+ // TODO: Implement setupSkinUserCss() method.
 63+ }
5264 }
5365
Index: branches/wmf/1.18wmf1/extensions/skins/Donate/Donate.class.php
@@ -35,12 +35,12 @@
3636 <script type="text/javascript" src="<?php echo htmlspecialchars( $this->getMainJs() ); ?>"></script>
3737 <link rel="stylesheet" href="<?php echo htmlspecialchars( $siteCss ); ?>" type="text/css"/>
3838 <script type="text/javascript" src="<?php echo htmlspecialchars( $siteJs ); ?>"></script>
39 -
 39+
4040 </head>
4141
4242 <body>
4343 <div align="center">
44 -
 44+
4545 <?php echo $bodyText ?>
4646 </div>
4747 </body>
@@ -48,5 +48,17 @@
4949
5050 <?php
5151 }
 52+
 53+ /**
 54+ * Add skin specific stylesheets
 55+ * Calling this method with an $out of anything but the same OutputPage
 56+ * inside ->getOutput() is deprecated. The $out arg is kept
 57+ * for compatibility purposes with skins.
 58+ * @param $out OutputPage
 59+ * @delete
 60+ */
 61+ function setupSkinUserCss(OutputPage $out) {
 62+ // TODO: Implement setupSkinUserCss() method.
 63+ }
5264 }
5365
Property changes on: branches/wmf/1.18wmf1/extensions/skins
___________________________________________________________________
Added: svn:mergeinfo
5466 Merged /branches/new-installer/phase3/extensions/skins:r43664-66004
5567 Merged /branches/REL1_15/phase3/extensions/skins:r51646
5668 Merged /branches/REL1_17/phase3/extensions/skins:r81445,81448
5769 Merged /trunk/extensions/skins:r99072
5870 Merged /branches/sqlite/extensions/skins:r58211-58321
5971 Merged /trunk/phase3/extensions/skins:r92580,92634,92713,92762,92765,92791,92854,92884,92886-92887,92894,92898,92907,92932,92958,93141,93149,93151,93233-93234,93258,93266,93303,93516-93518,93520,93818-93822,93847,93858,93891,93935-93936,94058,94062,94068,94107,94155,94235,94277,94346,94372,94422,94425,94444,94448,94456,94498,94517,94601,94630,94728,94738,94825,94862,94995-94997,95023,95042,95072-95073,95155,95327,95332,95410,95422,95426,95442,95468,95601,95812,98578,98598,98656

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99072Fix PHP Fatal error: Class SkinTomas contains 1 abstract method and must the...reedy01:39, 6 October 2011

Status & tagging log