r99040 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99039‎ | r99040 | r99041 >
Date:19:59, 5 October 2011
Author:ialex
Status:ok
Tags:
Comment:
Fix for r99038: this was in the wrong part of the if statement
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -262,6 +262,11 @@
263263 # a diff between a version V and its previous version V' AND the version V
264264 # is the first version of that article. In that case, V' does not exist.
265265 if ( $this->mOldRev === false ) {
 266+ $wgOut->setPageTitle( $this->mNewPage->getPrefixedText() );
 267+ $wgOut->setSubtitle( wfMsgExt( 'difference', array( 'parseinline' ) ) );
 268+ $samePage = true;
 269+ $oldHeader = '';
 270+ } else {
266271 wfRunHooks( 'DiffViewHeader', array( $this, $this->mOldRev, $this->mNewRev ) );
267272
268273 $sk = $wgUser->getSkin();
@@ -269,11 +274,6 @@
270275 $sk->suppressQuickbar();
271276 }
272277
273 - $wgOut->setPageTitle( $this->mNewPage->getPrefixedText() );
274 - $wgOut->setSubtitle( wfMsgExt( 'difference', array( 'parseinline' ) ) );
275 - $samePage = true;
276 - $oldHeader = '';
277 - } else {
278278 if ( $this->mNewPage->equals( $this->mOldPage ) ) {
279279 $wgOut->setPageTitle( $this->mNewPage->getPrefixedText() );
280280 $wgOut->setSubtitle( wfMsgExt( 'difference', array( 'parseinline' ) ) );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99038Big cleanup to DifferenceEngine:...ialex19:55, 5 October 2011

Status & tagging log