r98766 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98765‎ | r98766 | r98767 >
Date:14:18, 3 October 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18 MFT r98110, r98208, r98278, r98301
Modified paths:
  • /branches/REL1_18/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)
  • /branches/REL1_18/extensions/CheckUser/CheckUser_body.php (modified) (history)
  • /branches/REL1_18/extensions/OggHandler/OggHandler_body.php (modified) (history)
  • /branches/REL1_18/extensions/ParserFunctions/ParserFunctions_body.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/OggHandler/OggHandler_body.php
@@ -26,7 +26,6 @@
2727 return true;
2828 }
2929 if ( $name == 'thumbtime' ) {
30 - $length = $this->getLength( $image );
3130 $time = $this->parseTimeString( $value );
3231 if ( $time === false || $time <= 0 ) {
3332 return false;
Property changes on: branches/REL1_18/extensions/OggHandler/OggHandler_body.php
___________________________________________________________________
Added: svn:mergeinfo
3433 Merged /branches/wmf/1.18wmf1/extensions/OggHandler/OggHandler_body.php:r98207
3534 Merged /trunk/extensions/OggHandler/OggHandler_body.php:r98054,98110,98208,98278,98301
Index: branches/REL1_18/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -422,7 +422,7 @@
423423 var average = Math.round( ( rating.total / rating.count ) * 10 ) / 10;
424424 $(this)
425425 .find( '.articleFeedback-rating-average' )
426 - .text( average + ( average % 1 === 0 ? '.0' : '' ) )
 426+ .text( mw.language.convertNumber( average + ( average % 1 === 0 ? '.0' : '' ) , false ) )
427427 .end()
428428 .find( '.articleFeedback-rating-meter div' )
429429 .css( 'width', Math.round( average * 21 ) + 'px' )
Index: branches/REL1_18/extensions/CheckUser/CheckUser_body.php
@@ -1041,7 +1041,7 @@
10421042 # XFF string, link to /xff search
10431043 if ( $set[1] ) {
10441044 # Flag our trusted proxies
1045 - list( $client, $trusted ) = efGetClientIPfromXFF( $set[1], $set[0] );
 1045+ list( $client, $trusted ) = CheckUserHooks::getClientIPfromXFF( $set[1], $set[0] );
10461046 $c = $trusted ? '#F0FFF0' : '#FFFFCC';
10471047 $s .= '&#160;&#160;&#160;<span style="background-color: ' . $c . '"><strong>XFF</strong>: ';
10481048 $s .= $this->sk->makeKnownLinkObj( $this->getTitle(),
@@ -1184,7 +1184,7 @@
11851185 # XFF
11861186 if ( $row->cuc_xff != null ) {
11871187 # Flag our trusted proxies
1188 - list( $client, $trusted ) = efGetClientIPfromXFF( $row->cuc_xff, $row->cuc_ip );
 1188+ list( $client, $trusted ) = CheckUserHooks::getClientIPfromXFF( $row->cuc_xff, $row->cuc_ip );
11891189 $c = $trusted ? '#F0FFF0' : '#FFFFCC';
11901190 $line .= '&#160;&#160;&#160;<span class="mw-checkuser-xff" style="background-color: ' . $c . '">' .
11911191 '<strong>XFF</strong>: ';
Index: branches/REL1_18/extensions/ParserFunctions/ParserFunctions_body.php
@@ -505,7 +505,7 @@
506506 return '<strong class="error">' . wfMsgForContent( 'pfunc_time_too_long' ) . '</strong>';
507507 } else {
508508 if ( $ts < 100000000000000 ) { // Language can't deal with years after 9999
509 - if ( Language::isValidBuiltInCode( $language ) ) {
 509+ if ( $language !== '' && Language::isValidBuiltInCode( $language ) ) {
510510 // use whatever language is passed as a parameter
511511 $langObject = Language::factory( $language );
512512 $result = $langObject->sprintfDate( $format, $ts );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98110Show Decimal mark in ArticleFeedback rating as per the language rules. Ref Bu...santhosh05:08, 26 September 2011
r98208Fix for r87923, which made broken but harmless code from r62223 actually star...tstarling04:19, 27 September 2011
r98278Revert r92572: Language::isValidBuiltInCode() only rejected the empty string ...tstarling22:47, 27 September 2011
r98301Bug 31207 - wikimedia error while trying to preform a CUreedy11:13, 28 September 2011

Status & tagging log