r98767 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98766‎ | r98767 | r98768 >
Date:14:21, 3 October 2011
Author:ialex
Status:ok
Tags:
Comment:
Removed call to OutputPage::setSyndicated( true ) just before calling OutputPage::setFeedAppendQuery(); the former is useless when calling the latter
Modified paths:
  • /trunk/phase3/includes/HistoryPage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialNewpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HistoryPage.php
@@ -88,7 +88,6 @@
8989 $out->setArticleFlag( false );
9090 $out->setArticleRelated( true );
9191 $out->setRobotPolicy( 'noindex,nofollow' );
92 - $out->setSyndicated( true );
9392 $out->setFeedAppendQuery( 'action=history' );
9493 $out->addModules( array( 'mediawiki.legacy.history', 'mediawiki.action.history' ) );
9594
Index: trunk/phase3/includes/specials/SpecialNewpages.php
@@ -139,11 +139,12 @@
140140 // Settings
141141 $this->form();
142142
143 - $this->setSyndicated();
144143 $feedType = $this->opts->getValue( 'feed' );
145144 if( $feedType ) {
146145 return $this->feed( $feedType );
147146 }
 147+
 148+ $out->setFeedAppendQuery( wfArrayToCGI( $this->opts->getAllValues() ) );
148149 }
149150
150151 $pager = new NewPagesPager( $this, $this->opts );
@@ -276,12 +277,6 @@
277278 $this->getOutput()->addHTML( $form );
278279 }
279280
280 - protected function setSyndicated() {
281 - $out = $this->getOutput();
282 - $out->setSyndicated( true );
283 - $out->setFeedAppendQuery( wfArrayToCGI( $this->opts->getAllValues() ) );
284 - }
285 -
286281 /**
287282 * Format a row, providing the timestamp, links to the page/history, size, user links, and a comment
288283 *

Status & tagging log