r92572 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92571‎ | r92572 | r92573 >
Date:20:31, 19 July 2011
Author:kaldari
Status:reverted
Tags:
Comment:
follow up to r87308 - fix redundancy
Modified paths:
  • /trunk/extensions/ParserFunctions/ParserFunctions_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ParserFunctions/ParserFunctions_body.php
@@ -505,7 +505,7 @@
506506 return '<strong class="error">' . wfMsgForContent( 'pfunc_time_too_long' ) . '</strong>';
507507 } else {
508508 if ( $ts < 100000000000000 ) { // Language can't deal with years after 9999
509 - if ( $language !== '' && Language::isValidBuiltInCode( $language ) ) {
 509+ if ( Language::isValidBuiltInCode( $language ) ) {
510510 // use whatever language is passed as a parameter
511511 $langObject = Language::factory( $language );
512512 $result = $langObject->sprintfDate( $format, $ts );

Follow-up revisions

RevisionCommit summaryAuthorDate
r95628MFT to REL1_18 (extensions)...hashar15:32, 28 August 2011
r98278Revert r92572: Language::isValidBuiltInCode() only rejected the empty string ...tstarling22:47, 27 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87308better language handling - abandon magic language switch in favor of using in...kaldari23:30, 2 May 2011

Status & tagging log