r98740 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98739‎ | r98740 | r98741 >
Date:06:11, 3 October 2011
Author:petrb
Status:resolved (Comments)
Tags:
Comment:
Fixed missing "=" in ApiDelete.php
Modified paths:
  • /branches/petrb/phase3/includes/api/ApiDelete.php (modified) (history)

Diff [purge]

Index: branches/petrb/phase3/includes/api/ApiDelete.php
——@@ -272,7 +272,7 @@
273273 public function getExamples() {
274274 return array(
275275 'api.php?action=delete&title=Main%20Page&token=' . EXAMPLE_TOKEN,
276 - 'api.php?action=delete&title=Main%20Page&token' . EXAMPLE_TOKEN . '&reason=Preparing%20for%20move'
 276+ 'api.php?action=delete&title=Main%20Page&token=' . EXAMPLE_TOKEN . '&reason=Preparing%20for%20move'
277277 );
278278 }
279279
——@@ -282,5 +282,3 @@
283283
284284 public function getVersion() {
285285 return __CLASS__ . ': $Id$';
286 - }
287 -}

Follow-up revisions

RevisionCommit summaryAuthorDate
r98987fixed I have no clue how what I did that it got removed, now it should be okpetrb08:59, 5 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98614Created EXAMPLE_TOKEN which replaces all tokens in api examples and also look...petrb08:27, 1 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   16:00, 3 October 2011

That looks like a syntax terror at the end of the file.

#Comment by Petrb (talk | contribs)   06:15, 6 October 2011

resolved

#Comment by Petrb (talk | contribs)   13:07, 12 October 2011

could someone review it? - it's still marked wrong, also is there any possibility to get some of code into trunk

#Comment by Nikerabbit (talk | contribs)   13:10, 12 October 2011

Have you finished working on the feature?

#Comment by Petrb (talk | contribs)   13:24, 12 October 2011

it's not really a feature, I just updated the text of example, but unless someone is against this change, it's finished

Status & tagging log