r98739 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98738‎ | r98739 | r98740 >
Date:05:32, 3 October 2011
Author:aaron
Status:ok
Tags:
Comment:
Follow-up r98698: cache urls with 'version' param...which is kind if important
Modified paths:
  • /trunk/phase3/includes/cache/ResourceFileCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/cache/ResourceFileCache.php
@@ -47,8 +47,8 @@
4848 // Get all query values
4949 $queryVals = $context->getRequest()->getValues();
5050 foreach ( $queryVals as $query => $val ) {
51 - if ( $query === 'modules' || $query === '*' ) { // &* added as IE fix
52 - continue;
 51+ if ( $query === 'modules' || $query === 'version' || $query === '*' ) {
 52+ continue; // note: &* added as IE fix
5353 } elseif ( $query === 'skin' && $val === $wgDefaultSkin ) {
5454 continue;
5555 } elseif ( $query === 'lang' && $val === $wgLanguageCode ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98698FileCache:...aaron17:53, 2 October 2011

Status & tagging log