r98738 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98737‎ | r98738 | r98739 >
Date:03:35, 3 October 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Followup r97138 - could not reproduce myself
Modified paths:
  • /trunk/phase3/includes/logging/LogFormatter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/logging/LogFormatter.php
@@ -378,7 +378,7 @@
379379 if ( in_array( $subtype, array( 'event', 'revision' ) ) ) {
380380 if (
381381 ($subtype === 'event' && count( $params ) === 6 ) ||
382 - ($subtype === 'revision' && $params[3] === 'revision' )
 382+ ($subtype === 'revision' && isset( $params[3] ) && $params[3] === 'revision' )
383383 ) {
384384 $paramStart = $subtype === 'revision' ? 4 : 3;
385385

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97138This should fix the following PHP notice and the display of some yet another ...nikerabbit07:51, 15 September 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   01:38, 4 November 2011

Maybe these checks could be moved to a private function?

Status & tagging log