r98659 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98658‎ | r98659 | r98660 >
Date:07:06, 2 October 2011
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Respond to CR on r96225: use rawParam
Modified paths:
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewDiff.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewDiff.php
——@@ -191,17 +191,15 @@
192192 $headings .= Xml::tags( 'th', null,
193193 wfMsgExt( 'abusefilter-diff-item', 'parseinline' ) );
194194 $headings .= Xml::tags( 'th', null,
195 - wfMsgExt( 'abusefilter-diff-version',
196 - array( 'parseinline' ),
197 - array( $oldLink, $oldUserLink,
 195+ wfMessage( 'abusefilter-diff-version' )
 196+ ->rawParams($oldLink, $oldUserLink,
198197 $newVersion['meta']['modified_by_text'] )
199 - )
 198+ ->parse()
200199 );
201200 $headings .= Xml::tags( 'th', null,
202 - wfMsgExt( 'abusefilter-diff-version',
203 - array( 'parseinline' ),
204 - array( $newLink, $newUserLink )
205 - )
 201+ wfMessage('abusefilter-diff-version')
 202+ ->rawParams($newLink, $newUserLink)
 203+ ->parse()
206204 );
207205
208206 $headings = Xml::tags( 'tr', null, $headings );

Follow-up revisions

RevisionCommit summaryAuthorDate
r108844Fix r98659 per Nikerabbitreedy20:41, 13 January 2012

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96225Do not use replaceafter, per r52735 CRwerdna14:12, 4 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   16:53, 2 October 2011 
$newVersion['meta']['modified_by_text']

should be in normal params, because it is needed for gender. So the whole monster would be:

wfMessage( 'abusefilter-diff-version' )->rawParams( $oldLink, $oldUserLink )->params( $newVersion['meta']['modified_by_text'] )->parse()

#Comment by Reedy (talk | contribs)   20:20, 13 January 2012

Niklas would you mind resolving this and committing the correct version?

Status & tagging log