r96225 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96224‎ | r96225 | r96226 >
Date:14:12, 4 September 2011
Author:werdna
Status:ok (Comments)
Tags:
Comment:
Do not use replaceafter, per r52735 CR
Modified paths:
  • /trunk/extensions/AbuseFilter/Views/AbuseFilterViewDiff.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewDiff.php
——@@ -192,14 +192,14 @@
193193 wfMsgExt( 'abusefilter-diff-item', 'parseinline' ) );
194194 $headings .= Xml::tags( 'th', null,
195195 wfMsgExt( 'abusefilter-diff-version',
196 - array( 'parseinline', 'replaceafter' ),
 196+ array( 'parseinline' ),
197197 array( $oldLink, $oldUserLink,
198198 $newVersion['meta']['modified_by_text'] )
199199 )
200200 );
201201 $headings .= Xml::tags( 'th', null,
202202 wfMsgExt( 'abusefilter-diff-version',
203 - array( 'parseinline', 'replaceafter' ),
 203+ array( 'parseinline' ),
204204 array( $newLink, $newUserLink )
205205 )
206206 );

Follow-up revisions

RevisionCommit summaryAuthorDate
r98659Respond to CR on r96225: use rawParamwerdna07:06, 2 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r52735GENDER support for abusefilter-diff-versionwerdna12:55, 3 July 2009

Comments

#Comment by Nikerabbit (talk | contribs)   09:53, 21 September 2011

But now the html links are mangled by the parser. What you need is wfMessage with selective replaceafter... called rawParams.

#Comment by Werdna (talk | contribs)   07:06, 2 October 2011

Done.

Status & tagging log