r98619 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98618‎ | r98619 | r98620 >
Date:18:42, 1 October 2011
Author:santhosh
Status:ok (Comments)
Tags:
Comment:
Fix Bug 29299 - Zero should be considered plural for pt-br
Modified paths:
  • /trunk/phase3/resources/mediawiki.language/languages/pt-br.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.language/languages/pt-br.js
——@@ -4,7 +4,7 @@
55
66 mediaWiki.language.convertPlural = function( count, forms ) {
77 forms = mediaWiki.language.preConvertPlural( forms, 2 );
8 - return ( count <= 1 ) ? forms[0] : forms[1];
 8+ return ( count == 1 ) ? forms[0] : forms[1];
99 };
1010
1111 mediaWiki.language.digitTransformTable = {

Follow-up revisions

RevisionCommit summaryAuthorDate
r98635mediaWiki.language.convertPlural not required since it is same as the default...santhosh22:34, 1 October 2011
r98765REL1_18: MFT r98111, r98113, r98185, r98253, r98297, r98619, r98635reedy14:06, 3 October 2011
r987771.18wmf1: MFT r98054, r98110, r98111, r98113, r98253, r98297, r98619, r98635catrope17:26, 3 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   18:50, 1 October 2011

I don't see this rule on the PHP side.

#Comment by Santhosh.thottingal (talk | contribs)   18:57, 1 October 2011

It is there in the default convertPlural method of Language.php

#Comment by Santhosh.thottingal (talk | contribs)   23:17, 1 October 2011

removed this method in r98635 since it is same as default implementation after this revision.

Status & tagging log