r98111 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98110‎ | r98111 | r98112 >
Date:05:23, 26 September 2011
Author:santhosh
Status:ok (Comments)
Tags:
Comment:
Add digitTransformTable for pt, pt-br and nl
Modified paths:
  • /trunk/phase3/resources/mediawiki.language/languages/nl.js (added) (history)
  • /trunk/phase3/resources/mediawiki.language/languages/pt-br.js (modified) (history)
  • /trunk/phase3/resources/mediawiki.language/languages/pt.js (added) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.language/languages/pt-br.js
——@@ -6,3 +6,8 @@
77 forms = mediaWiki.language.preConvertPlural( forms, 2 );
88 return ( count <= 1 ) ? forms[0] : forms[1];
99 };
 10+
 11+mediaWiki.language.digitTransformTable = {
 12+ '.' : ',',
 13+ ',' : ' '
 14+};
Index: trunk/phase3/resources/mediawiki.language/languages/nl.js
——@@ -0,0 +1,8 @@
 2+/**
 3+ * Dutch (Nederlands) language functions
 4+ */
 5+
 6+mediaWiki.language.digitTransformTable = {
 7+ '.' : ',',
 8+ ',' : '.'
 9+};
Property changes on: trunk/phase3/resources/mediawiki.language/languages/nl.js
___________________________________________________________________
Added: svn:eol-style
110 + native
Index: trunk/phase3/resources/mediawiki.language/languages/pt.js
——@@ -0,0 +1,8 @@
 2+/**
 3+ * Portugese language functions
 4+ */
 5+
 6+mediaWiki.language.digitTransformTable = {
 7+ '.' : ',',
 8+ ',' : ' '
 9+};
Property changes on: trunk/phase3/resources/mediawiki.language/languages/pt.js
___________________________________________________________________
Added: svn:eol-style
110 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r98113Add mediawiki.language/languages/nl.js and mediawiki.language/languages/pt.jssanthosh06:08, 26 September 2011
r98765REL1_18: MFT r98111, r98113, r98185, r98253, r98297, r98619, r98635reedy14:06, 3 October 2011
r987771.18wmf1: MFT r98054, r98110, r98111, r98113, r98253, r98297, r98619, r98635catrope17:26, 3 October 2011

Comments

#Comment by Nikerabbit (talk | contribs)   05:51, 26 September 2011

It's going to be impossible to keep these two in sync, sigh. 

Portugese -> Portuguese
#Comment by Bawolff (talk | contribs)   15:11, 29 September 2011

Why can't digit transform tables be generated automatically from (php) Language files by the resource loader?

#Comment by Nikerabbit (talk | contribs)   16:26, 29 September 2011

Because nobody hasn't done it.

Status & tagging log