r98589 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98588‎ | r98589 | r98590 >
Date:00:17, 1 October 2011
Author:awjrichards
Status:ok
Tags:
Comment:
ResourceLoader-ifying lightbox rapidhtml form
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/lightbox1.html (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/html/lightbox1.html
@@ -1,30 +1,9 @@
2 -<!-- load styles from original first steps -->
32 <!--[if lt IE 7]><style type="text/css">body{behavior:url("/w/skins-1.17/vector/csshover.min.htc")}</style><![endif]-->
4 -<!-- start Webitects styles -->
5 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.js'></script>
6 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.client.js'></script>
7 -<!--
8 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.min.js'></script>
9 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.core.js'></script>
10 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.widget.js'></script>
11 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.mouse.js'></script>
12 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.position.js'></script>
13 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.draggable.js'></script>
14 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.resizable.js'></script>
15 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.button.js'></script>
16 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/jquery.ui.dialog.js'></script>
 3+<script type="text/javascript">
 4+mw.loader.load('pfp.form.rapidhtml.lightbox.js');
 5+mw.loader.load('pfp.form.rapidhtml.lightbox.css');
 6+</script>
177
18 -<script type='text/javascript' src='@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/lightbox1.js'></script>
19 -<link rel="stylesheet" href="@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/jquery.ui.core.css" />
20 -<link rel="stylesheet" href="@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/jquery.ui.theme.css" />
21 -<link rel="stylesheet" href="@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/jquery.ui.dialog.css" />
22 -<link rel="stylesheet" href="@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/jquery.ui.button.css" />
23 -<link rel="stylesheet" href="@script_path/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/css/lightbox1.css" />
24 -<style type="text/css">
25 -
26 -</style>
27 -
288 <div class="ltr">
299 <div id="appeal">
3010 <div id="appeal-content">
@@ -263,4 +242,4 @@
264243 </fieldset>
265244 </form>
266245 </div>
267 -</div>
\ No newline at end of file
 246+</div>
Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php
@@ -183,6 +183,32 @@
184184 'remoteExtPath' => 'DonationInterface/payflowpro_gateway'
185185 );
186186
 187+$wgResourceModules[ 'pfp.form.rapidhtml.lightbox.js' ] = array(
 188+ 'scripts' => array(
 189+ 'forms/rapidhtml/js/lightbox1.js',
 190+ ),
 191+ 'dependencies' => array(
 192+ 'jquery.ui.dialog',
 193+ ),
 194+ 'localBasePath' => dirname( __FILE__ ),
 195+ 'remoteExtPath' => 'DonationInterface/payflowpro_gateway',
 196+ 'position' => 'top',
 197+);
 198+
 199+$wgResourceModules[ 'pfp.form.rapidhtml.lightbox.css' ] = array(
 200+ 'styles' => array(
 201+ 'forms/rapidhtml/css/jquery.ui.core.css',
 202+ 'forms/rapidhtml/css/jquery.ui.theme.css',
 203+ 'forms/rapidhtml/css/jquery.ui.dialog.css',
 204+ 'forms/rapidhtml/css/jquery.ui.button.css',
 205+ 'forms/rapidhtml/css/lightbox1.css',
 206+ ),
 207+ 'localBasePath' => dirname( __FILE__ ),
 208+ 'remoteExtPath' => 'DonationInterface/payflowpro_gateway',
 209+ 'position' => 'top',
 210+);
 211+
 212+
187213 function payflowGatewayConnection() {
188214 global $wgPayflowGatewayDBserver, $wgPayflowGatewayDBname;
189215 global $wgPayflowGatewayDBuser, $wgPayflowGatewayDBpassword;

Follow-up revisions

RevisionCommit summaryAuthorDate
r98600fixing up some resourceloader stuff for lightbox form - follow-up for r98589....kaldari03:15, 1 October 2011
r100196Merging the fundraising branch of DonationInterface back into trunk....khorn00:47, 19 October 2011

Status & tagging log