r98600 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98599‎ | r98600 | r98601 >
Date:03:15, 1 October 2011
Author:kaldari
Status:ok
Tags:
Comment:
fixing up some resourceloader stuff for lightbox form - follow-up for r98589. jQuery UI CSS comes for free with the respective modules, BTW
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/lightbox1.js (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/rapidhtml/js/lightbox1.js
@@ -41,7 +41,7 @@
4242 $( '#steps .step' ).each( function(i) {
4343 var $step = $( this );
4444 widths[i] = stepsWidth;
45 - stepsWidth += $step.width();
 45+ stepsWidth += 600; // Hard-coding as $.width() is not working for some reason
4646 } );
4747 $( '#steps' ).width( stepsWidth );
4848
Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php
@@ -188,6 +188,13 @@
189189 'forms/rapidhtml/js/lightbox1.js',
190190 ),
191191 'dependencies' => array(
 192+ 'jquery.ui.core',
 193+ 'jquery.ui.widget',
 194+ 'jquery.ui.mouse',
 195+ 'jquery.ui.position',
 196+ 'jquery.ui.draggable',
 197+ 'jquery.ui.resizable',
 198+ 'jquery.ui.button',
192199 'jquery.ui.dialog',
193200 ),
194201 'localBasePath' => dirname( __FILE__ ),
@@ -197,10 +204,6 @@
198205
199206 $wgResourceModules[ 'pfp.form.rapidhtml.lightbox.css' ] = array(
200207 'styles' => array(
201 - 'forms/rapidhtml/css/jquery.ui.core.css',
202 - 'forms/rapidhtml/css/jquery.ui.theme.css',
203 - 'forms/rapidhtml/css/jquery.ui.dialog.css',
204 - 'forms/rapidhtml/css/jquery.ui.button.css',
205208 'forms/rapidhtml/css/lightbox1.css',
206209 ),
207210 'localBasePath' => dirname( __FILE__ ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r100196Merging the fundraising branch of DonationInterface back into trunk....khorn00:47, 19 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98589ResourceLoader-ifying lightbox rapidhtml formawjrichards00:17, 1 October 2011

Status & tagging log