r98566 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98565‎ | r98566 | r98567 >
Date:21:19, 30 September 2011
Author:preilly
Status:deferred (Comments)
Tags:mobile 
Comment:
fix for bug 31214 - ipad apps - mobile article does not fit if webview width < 768
Modified paths:
  • /trunk/extensions/MobileFrontend/views/layout/application.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/views/layout/application.html.php
——@@ -24,7 +24,7 @@
2525 <meta http-equiv="content-type" content="application/xhtml+xml; charset=utf-8" />
2626 <link href='{$wgExtensionAssetsPath}/MobileFrontend/stylesheets/{$cssFileName}.css' media='all' rel='Stylesheet' type='text/css' />
2727 <meta name="ROBOTS" content="NOINDEX, NOFOLLOW" />
28 - <meta name = "viewport" content = "width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0" />
 28+ <meta name = "viewport" content = "width=device-width; initial-scale=1.0; maximum-scale=1.0; user-scalable=0;" />
2929 ${appleTouchIconTag}
3030 <script type='text/javascript'>
3131 //<![CDATA[

Follow-up revisions

RevisionCommit summaryAuthorDate
r98567mft r98566preilly21:21, 30 September 2011
r98568mft r98566preilly21:21, 30 September 2011
r113463use max-width for viewport not width...jdlrobson11:03, 9 March 2012

Comments

#Comment by G.Hagedorn (talk | contribs)   23:14, 30 September 2011

may need 1.18 tag

#Comment by Preilly (talk | contribs)   23:16, 30 September 2011

Added.

#Comment by Nikerabbit (talk | contribs)   06:16, 1 October 2011

I don't understand how the commit message is related to actual code changes.

#Comment by TheDJ (talk | contribs)   08:43, 1 October 2011

This is not valid syntax for the viewport tag (Reason that i changed it in the first place). Better just remove everything after "width=device-width", which was the part being ignored due to incorrect syntax.

Status & tagging log