r98568 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98567‎ | r98568 | r98569 >
Date:21:21, 30 September 2011
Author:preilly
Status:ok
Tags:
Comment:
mft r98566
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/MobileFrontend/views/layout/application.html.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/MobileFrontend/views/layout/application.html.php
@@ -4,7 +4,7 @@
55 $dir = self::$dir;
66 $code = self::$code;
77
8 -if( $wgAppleTouchIcon !== false ) {
 8+if ( $wgAppleTouchIcon !== false ) {
99 $appleTouchIconTag = Html::element( 'link', array( 'rel' => 'apple-touch-icon', 'href' => $wgAppleTouchIcon ) );
1010 } else {
1111 $appleTouchIconTag = "";
@@ -20,20 +20,20 @@
2121 "http://www.openmobilealliance.org/tech/DTD/xhtml-mobile12.dtd">
2222 <html lang='{$code}' dir='{$dir}' xml:lang='{$code}' xmlns='http://www.w3.org/1999/xhtml'>
2323 <head>
24 - <title>{$htmlTitle}</title>
25 - <meta http-equiv="content-type" content="application/xhtml+xml; charset=utf-8" />
26 - <link href='{$wgExtensionAssetsPath}/MobileFrontend/stylesheets/{$cssFileName}.css' media='all' rel='Stylesheet' type='text/css' />
27 - <meta name="ROBOTS" content="NOINDEX, NOFOLLOW" />
28 - <meta name = "viewport" content = "width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0" />
29 - ${appleTouchIconTag}
30 - <script type='text/javascript'>
31 - //<![CDATA[
32 - var title = "{$htmlTitle}";
33 - function shouldCache() {
34 - return true;
35 - }
36 - //]]>
37 - </script>
 24+ <title>{$htmlTitle}</title>
 25+ <meta http-equiv="content-type" content="application/xhtml+xml; charset=utf-8" />
 26+ <link href='{$wgExtensionAssetsPath}/MobileFrontend/stylesheets/{$cssFileName}.css' media='all' rel='Stylesheet' type='text/css' />
 27+ <meta name="ROBOTS" content="NOINDEX, NOFOLLOW" />
 28+ <meta name = "viewport" content = "width=device-width; initial-scale=1.0; maximum-scale=1.0; user-scalable=0;" />
 29+ ${appleTouchIconTag}
 30+ <script type='text/javascript'>
 31+ //<![CDATA[
 32+ var title = "{$htmlTitle}";
 33+ function shouldCache() {
 34+ return true;
 35+ }
 36+ //]]>
 37+ </script>
3838 </head>
3939 <body>
4040 {$searchWebkitHtml}
@@ -42,7 +42,7 @@
4343 {$contentHtml}
4444 </div>
4545 {$footerHtml}
46 - <script type="text/javascript" language="javascript" src="{$wgExtensionAssetsPath}/MobileFrontend/javascripts/application.js?version=20110919T172820Z"></script>
 46+ <script type="text/javascript" language="javascript" src="{$wgExtensionAssetsPath}/MobileFrontend/javascripts/application.js?version=20110920T172820Z"></script>
4747 </body>
4848 </html>
4949 EOT;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98566fix for bug 31214 - ipad apps - mobile article does not fit if webview width ...preilly21:19, 30 September 2011

Status & tagging log