r98412 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98411‎ | r98412 | r98413 >
Date:15:21, 29 September 2011
Author:ialex
Status:resolved (Comments)
Tags:
Comment:
Per Aaron, follow-up r96859: add @deprecated comment, a wfDeprecated() and mark it for removal in next version since it's not used anywhere
Modified paths:
  • /trunk/phase3/includes/parser/ParserOptions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/ParserOptions.php
@@ -137,7 +137,9 @@
138138 function setNumberHeadings( $x ) { return wfSetVar( $this->mNumberHeadings, $x ); }
139139 function setAllowSpecialInclusion( $x ) { return wfSetVar( $this->mAllowSpecialInclusion, $x ); }
140140 function setTidy( $x ) { return wfSetVar( $this->mTidy, $x ); }
141 - function setSkin( $x ) {}
 141+
 142+ /** @deprecated in 1.19; will be removed in 1.20 */
 143+ function setSkin( $x ) { wfDeprecated( __METHOD__ ); }
142144 function setInterfaceMessage( $x ) { return wfSetVar( $this->mInterfaceMessage, $x ); }
143145 function setTargetLanguage( $x ) { return wfSetVar( $this->mTargetLanguage, $x, true ); }
144146 function setMaxIncludeSize( $x ) { return wfSetVar( $this->mMaxIncludeSize, $x ); }

Follow-up revisions

RevisionCommit summaryAuthorDate
r98460FU r98412: added version to wfDeprecated callaaron21:30, 29 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96859Turn ParserOptions::setSkin() into a no-op since mSkin is no more usedialex16:29, 12 September 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   15:43, 29 September 2011

We usually add @deprecated to one MW version, wfDeprecated() to the next, and then remove later.

I suppose it doesn't matter if there are no callers now.

#Comment by Dantman (talk | contribs)   15:46, 29 September 2011

We have wfDeprecated( __METHOD__, '1.19' ); support now instead of that pattern.

#Comment by Dantman (talk | contribs)   15:46, 29 September 2011

We have wfDeprecated( __METHOD__, '1.19' ); support now instead of that pattern.

#Comment by Aaron Schulz (talk | contribs)   15:47, 29 September 2011

Nice, makes for less to remember :)

Status & tagging log