r96859 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96858‎ | r96859 | r96860 >
Date:16:29, 12 September 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Turn ParserOptions::setSkin() into a no-op since mSkin is no more used
Modified paths:
  • /trunk/phase3/includes/parser/ParserOptions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/ParserOptions.php
@@ -137,7 +137,7 @@
138138 function setNumberHeadings( $x ) { return wfSetVar( $this->mNumberHeadings, $x ); }
139139 function setAllowSpecialInclusion( $x ) { return wfSetVar( $this->mAllowSpecialInclusion, $x ); }
140140 function setTidy( $x ) { return wfSetVar( $this->mTidy, $x ); }
141 - function setSkin( $x ) { $this->mSkin = $x; }
 141+ function setSkin( $x ) {}
142142 function setInterfaceMessage( $x ) { return wfSetVar( $this->mInterfaceMessage, $x ); }
143143 function setTargetLanguage( $x ) { return wfSetVar( $this->mTargetLanguage, $x, true ); }
144144 function setMaxIncludeSize( $x ) { return wfSetVar( $this->mMaxIncludeSize, $x ); }

Follow-up revisions

RevisionCommit summaryAuthorDate
r98412Per Aaron, follow-up r96859: add @deprecated comment, a wfDeprecated() and ma...ialex15:21, 29 September 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   20:58, 28 September 2011

Please add a @deprecated comment.

#Comment by IAlex (talk | contribs)   15:22, 29 September 2011

Done in r98412.

Status & tagging log