r98309 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98308‎ | r98309 | r98310 >
Date:13:41, 28 September 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: Merge r98308 from 1.17wmf1
Modified paths:
  • /branches/wmf/1.18wmf1/includes/Title.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/parser/ParserCache.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/Title.php
@@ -855,7 +855,7 @@
856856
857857 // Ugly quick hack to avoid duplicate prefixes (bug 4571 etc)
858858 // Correct fix would be to move the prepending elsewhere.
859 - if ( $wgRequest->getVal( 'action' ) != 'render' ) {
 859+ if ( $wgRequest->getVal( 'action' ) != 'render' && $wgRequest->getVal( 'action' ) != 'parse' ) {
860860 $url = $wgServer . $url;
861861 }
862862 } else {
Property changes on: branches/wmf/1.18wmf1/includes/Title.php
___________________________________________________________________
Modified: svn:mergeinfo
863863 Merged /branches/wmf/1.17wmf1/includes/Title.php:r98308
Index: branches/wmf/1.18wmf1/includes/parser/ParserCache.php
@@ -48,7 +48,7 @@
4949
5050 // idhash seem to mean 'page id' + 'rendering hash' (r3710)
5151 $pageid = $article->getID();
52 - $renderkey = (int)($wgRequest->getVal('action') == 'render') + 2*(int)($wgRequest->getVal('action') == 'parse');
 52+ $renderkey = (int)($wgRequest->getVal('action') == 'render') + 3*(int)($wgRequest->getVal('action') == 'parse');
5353
5454 $key = wfMemcKey( 'pcache', 'idhash', "{$pageid}-{$renderkey}!{$hash}" );
5555 return $key;

Follow-up revisions

RevisionCommit summaryAuthorDate
r997171.18wmf1: Revert r98306, r98309, r98311, r98929 (action=parse iOS hack)catrope18:50, 13 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98308Followup r98305: fix borked URLs with double server names due to an extra act...catrope13:40, 28 September 2011

Status & tagging log