r99717 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99716‎ | r99717 | r99718 >
Date:18:50, 13 October 2011
Author:catrope
Status:ok
Tags:
Comment:
1.18wmf1: Revert r98306, r98309, r98311, r98929 (action=parse iOS hack)
Modified paths:
  • /branches/wmf/1.18wmf1/includes/Title.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/parser/ParserCache.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/parser/ParserCache.php
@@ -48,7 +48,7 @@
4949
5050 // idhash seem to mean 'page id' + 'rendering hash' (r3710)
5151 $pageid = $article->getID();
52 - $renderkey = (int)($wgRequest->getVal('action') == 'render') + 5*(int)($wgRequest->getVal('action') == 'parse');
 52+ $renderkey = (int)($wgRequest->getVal('action') == 'render');
5353
5454 $key = wfMemcKey( 'pcache', 'idhash', "{$pageid}-{$renderkey}!{$hash}" );
5555 return $key;
Index: branches/wmf/1.18wmf1/includes/Title.php
@@ -855,7 +855,7 @@
856856
857857 // Ugly quick hack to avoid duplicate prefixes (bug 4571 etc)
858858 // Correct fix would be to move the prepending elsewhere.
859 - if ( $wgRequest->getVal( 'action' ) != 'render' && $wgRequest->getVal( 'action' ) != 'parse' ) {
 859+ if ( $wgRequest->getVal( 'action' ) != 'render' ) {
860860 $url = $wgServer . $url;
861861 }
862862 } else {
@@ -953,12 +953,6 @@
954954 if ( $wgRequest->getVal( 'action' ) == 'render' ) {
955955 $url = $wgServer . $url;
956956 }
957 -
958 - // HACK for iOS issue: expand URLs to absolute in API action=parse
959 - // See http://lists.wikimedia.org/pipermail/mediawiki-api/2011-September/002361.html for details
960 - if ( $wgRequest->getVal( 'action' ) == 'parse' ) {
961 - $url = wfExpandUrl( $url, PROTO_CANONICAL );
962 - }
963957 }
964958 wfRunHooks( 'GetLocalURL', array( &$this, &$url, $query ) );
965959 return $url;
Property changes on: branches/wmf/1.18wmf1/includes/Title.php
___________________________________________________________________
Modified: svn:mergeinfo
966960 Reverse-merged /branches/wmf/1.17wmf1/includes/Title.php:r98308

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r983061.18wmf1: Merge 98305 from 1.17wmf1catrope13:22, 28 September 2011
r983091.18wmf1: Merge r98308 from 1.17wmf1catrope13:41, 28 September 2011
r983111.18wmf1: Merge r98310 from 1.17wmf1. I'm done messing around now, I promisecatrope13:50, 28 September 2011
r98929Commit live hack: bump the render hash number for action=parse againcatrope21:37, 4 October 2011

Status & tagging log