r98103 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r98102‎ | r98103 | r98104 >
Date:02:04, 26 September 2011
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Followup r98056; Add to this screwed up NewParserTest phpunit stuff as well.
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/parser/NewParserTest.php
——@@ -279,6 +279,7 @@
280280 'wgExternalLinkTarget' => false,
281281 'wgAlwaysUseTidy' => false,
282282 'wgHtml5' => true,
 283+ 'wgCleanupPresentationalAttributes' => true,
283284 'wgWellFormedXml' => true,
284285 'wgAllowMicrodataAttributes' => true,
285286 'wgAdaptiveMessageCache' => true,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98056Followup r98053; Add $wgCleanupPresentationalAttributes to the globals setup ...dantman04:35, 25 September 2011

Comments

#Comment by 😂 (talk | contribs)   13:43, 26 September 2011

It's not screwed up, it's intended to replace the old parser tests. Ideally, we should get rid of the old one.

#Comment by Dantman (talk | contribs)   20:56, 26 September 2011

;) Do that, and I won't be able to run parser tests anymore...

#Comment by Bawolff (talk | contribs)   20:58, 26 September 2011

I also like the old parser tests. The old parser tests are very easy to get working. phpunit is a pain to make it go-go (but once you do get it to work it is nice).

#Comment by 😂 (talk | contribs)   21:00, 26 September 2011 
apt-get install phpunit?
#Comment by Bawolff (talk | contribs)   21:01, 26 September 2011

gives you a phpunit that doesn't work with MediaWiki's tests (or at least used to whenever I first tried to install it)

#Comment by 😂 (talk | contribs)   21:02, 26 September 2011

The commandline `phpunit` won't work, but as long as all the classes are in PEAR, you should be fine :)

#Comment by Bawolff (talk | contribs)   21:06, 26 September 2011

Well should, but it didn't ;). I ended up just installing it using the pear command line tool, which worked well.

#Comment by 😂 (talk | contribs)   21:06, 26 September 2011

That works too :D

#Comment by Dantman (talk | contribs)   21:02, 26 September 2011

;) Hardcoded memory limits that make parser tests die unfinished while waiting for minutes are /fun/.

Status & tagging log