r98102 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98101‎ | r98102 | r98103 >
Date:01:06, 26 September 2011
Author:krinkle
Status:ok
Tags:
Comment:
[RL2] ext.gadgets.gadgetmanager: Fix self closing <html:key /> + i18n message
*The self-closing slash was missing in some cases, added them
*"Module properties" and "Gadget settings" localization is used now
Modified paths:
  • /branches/RL2/extensions/Gadgets/modules/ext.gadgets.gadgetmanager.js (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/modules/ext.gadgets.gadgetmanager.js
@@ -18,39 +18,39 @@
1919 tpl = {
2020 fancyForm: '<form class="mw-gadgetmanager-form">\
2121 <fieldset>\
22 - <legend>Module properties</legend>\
 22+ <legend><html:msg key="gadgetmanager-propsgroup-module" /></legend>\
2323 <table>\
2424 <tr>\
25 - <td><label for="mw-gadgetmanager-input-scripts"><html:msg key="gadgetmanager-prop-scripts"></label></td>\
 25+ <td><label for="mw-gadgetmanager-input-scripts"><html:msg key="gadgetmanager-prop-scripts" /></label></td>\
2626 <td><input type="text" id="mw-gadgetmanager-input-scripts" /></td>\
2727 </tr>\
2828 <tr>\
29 - <td><label for="mw-gadgetmanager-input-styles"><html:msg key="gadgetmanager-prop-styles"></label></td>\
 29+ <td><label for="mw-gadgetmanager-input-styles"><html:msg key="gadgetmanager-prop-styles" /></label></td>\
3030 <td><input type="text" id="mw-gadgetmanager-input-styles" /></td>\
3131 </tr>\
3232 <tr>\
33 - <td><label for="mw-gadgetmanager-input-dependencies"><html:msg key="gadgetmanager-prop-dependencies"></label></td>\
 33+ <td><label for="mw-gadgetmanager-input-dependencies"><html:msg key="gadgetmanager-prop-dependencies" /></label></td>\
3434 <td><input type="text" id="mw-gadgetmanager-input-dependencies" /></td>\
3535 </tr>\
3636 <tr>\
37 - <td><label for="mw-gadgetmanager-input-messages"><html:msg key="gadgetmanager-prop-messages"></label></td>\
 37+ <td><label for="mw-gadgetmanager-input-messages"><html:msg key="gadgetmanager-prop-messages" /></label></td>\
3838 <td><input type="text" id="mw-gadgetmanager-input-messages" /></td>\
3939 </tr>\
4040 </table>\
4141 </fieldset>\
4242 <fieldset>\
43 - <legend>Gadget settings</legend>\
 43+ <legend><html:msg key="gadgetmanager-propsgroup-settings" /></legend>\
4444 <table>\
4545 <tr>\
46 - <td><label for="mw-gadgetmanager-input-category"><html:msg key="gadgetmanager-prop-category"></label></td>\
 46+ <td><label for="mw-gadgetmanager-input-category"><html:msg key="gadgetmanager-prop-category" /></label></td>\
4747 <td><select id="mw-gadgetmanager-input-category"></select></td>\
4848 </tr>\
4949 <tr>\
50 - <td><label for="mw-gadgetmanager-input-rights"><html:msg key="gadgetmanager-prop-rights"></label></td>\
 50+ <td><label for="mw-gadgetmanager-input-rights"><html:msg key="gadgetmanager-prop-rights" /></label></td>\
5151 <td><input type="text" id="mw-gadgetmanager-input-rights" /></td>\
5252 </tr>\
5353 <tr>\
54 - <td><label for="mw-gadgetmanager-input-default"><html:msg key="gadgetmanager-prop-default"></label></td>\
 54+ <td><label for="mw-gadgetmanager-input-default"><html:msg key="gadgetmanager-prop-default" /></label></td>\
5555 <td><input type="checkbox" id="mw-gadgetmanager-input-default" /></td>\
5656 </tr>\
5757 <tr>\
@@ -58,7 +58,7 @@
5959 <td><input type="checkbox" id="mw-gadgetmanager-input-hidden" /></td>\
6060 </tr>\
6161 ' + ( ga.conf.enableSharing ? '<tr>\
62 - <td><label for="mw-gadgetmanager-input-shared"><html:msg key="gadgetmanager-prop-shared"></label></td>\
 62+ <td><label for="mw-gadgetmanager-input-shared"><html:msg key="gadgetmanager-prop-shared" /></label></td>\
6363 <td><input type="checkbox" id="mw-gadgetmanager-input-shared" /></td>\
6464 </tr>\
6565 ' : '' ) + '</table>\

Status & tagging log