r97837 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97836‎ | r97837 | r97838 >
Date:19:02, 22 September 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Fix

from within function "CodeRevision::getComments". Database returned error "1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '! IS NULL ORDER BY cc_sortkey' at line 1 (localhost)".
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
——@@ -781,9 +781,9 @@
782782 'cc_rev_id' => $this->id );
783783
784784 if( $attached ) {
785 - $conditions['cc_patch_line!'] = null;
 785+ $conditions['cc_patch_line'] = '!= null';
786786 } else {
787 - $conditions['cc_patch_line'] = null;
 787+ $conditions['cc_patch_line'] = null;
788788 }
789789
790790 $dbr = wfGetDB( DB_SLAVE );

Follow-up revisions

RevisionCommit summaryAuthorDate
r97846Fix r97837 properly...reedy20:07, 22 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   19:52, 22 September 2011

Does '!= null' really work?

#Comment by Dantman (talk | contribs)   19:56, 22 September 2011

What happened to the space that goes before "!"?

#Comment by Krinkle (talk | contribs)   12:10, 26 September 2011

Yeah, had the same error locally. Thanks!

Status & tagging log