r97846 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97845‎ | r97846 | r97847 >
Date:20:07, 22 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix r97837 properly

Fix documentation in DiffHighlighter.php
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)
  • /trunk/extensions/CodeReview/backend/DiffHighlighter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -778,10 +778,11 @@
779779 public function getComments( $attached = false ) {
780780 $conditions = array(
781781 'cc_repo_id' => $this->repoId,
782 - 'cc_rev_id' => $this->id );
 782+ 'cc_rev_id' => $this->id
 783+ );
783784
784785 if( $attached ) {
785 - $conditions['cc_patch_line'] = '!= null';
 786+ $conditions[] = 'cc_patch_line != null';
786787 } else {
787788 $conditions['cc_patch_line'] = null;
788789 }
Index: trunk/extensions/CodeReview/backend/DiffHighlighter.php
@@ -13,9 +13,14 @@
1414 /* line number inside patch */
1515 protected $lineNumber = 0;
1616
17 - /* CodeRepository: The repository for this revision */
 17+ /**
 18+ * @var CodeRepositor The repository for this revision
 19+ */
1820 protected $repo = null;
19 - /* CodeRevision: revision the diff comes from */
 21+
 22+ /**
 23+ * @var CodeRevision revision the diff comes from
 24+ */
2025 protected $rev = null;
2126
2227 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97837Fix...reedy19:02, 22 September 2011

Status & tagging log