r97589 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97588‎ | r97589 | r97590 >
Date:00:51, 20 September 2011
Author:asher
Status:ok
Tags:
Comment:
disable fast index creation before creating new primary key w/IGNORE
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/FlaggedRevs/schema/mysql/patch-fr_page_rev-index-wmf1.8.sql (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/FlaggedRevs/schema/mysql/patch-fr_page_rev-index-wmf1.8.sql
@@ -4,7 +4,11 @@
55 DROP PRIMARY KEY;
66
77 -- Take the first row of any duplicates on new key
 8+-- Must disable fast index creation as a workaround to
 9+-- http://bugs.mysql.com/bug.php?id=40344
 10+set session old_alter_table=1;
811 ALTER IGNORE TABLE /*_*/flaggedrevs ADD PRIMARY KEY (fr_rev_id);
 12+set session old_alter_table=0;
913
1014 CREATE INDEX /*i*/page_rev ON /*_*/flaggedrevs (fr_page_id,fr_rev_id);
1115 CREATE INDEX /*i*/page_time ON /*_*/flaggedrevs (fr_page_id,fr_rev_timestamp);

Status & tagging log