r97590 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r97589
|
r97590
|
r97591
>
Date:
01:28, 20 September 2011
Author:
tstarling
Status:
ok
Tags:
Comment:
Don't call Profiler::collateData() from ProfilerSimpleUDP, it destroys $this->mCollated which was filled by profileOut(), leading to a profile with only overhead entries. Call Profiler::close() instead, like what ProfilerSimpleText does.
Modified paths:
/trunk/phase3/includes/profiler/ProfilerSimpleUDP.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/profiler/ProfilerSimpleUDP.php
—
—
@@ -13,7 +13,7 @@
14
14
public function logData() {
15
15
global $wgUDPProfilerHost, $wgUDPProfilerPort;
16
16
17
- $this->collateData();
17
+ $this->close();
18
18
19
19
if ( isset( $this->mCollated['-total'] ) && $this->mCollated['-total']['real'] < $this->mMinimumTime ) {
20
20
# Less than minimum, ignore
Follow-up revisions
Revision
Commit summary
Author
Date
r97591
MFT
r97590
: fixed ProfilerSimpleUDP total breakage
tstarling
01:31, 20 September 2011
r97612
REL1_18: MFT
r97590
,
r97583
reedy
10:04, 20 September 2011
Status & tagging log
10:05, 20 September 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r97590
[
removed:
1.18]
08:16, 20 September 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r97590
[
added:
1.18]
03:20, 20 September 2011
Aaron Schulz
(
talk
|
contribs
)
changed the
status
of r97590
[
removed:
new
added:
ok]