r97588 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97587‎ | r97588 | r97589 >
Date:00:30, 20 September 2011
Author:reedy
Status:reverted
Tags:
Comment:
PHP fatal error in /usr/local/apache/common-local/php-1.18/includes/OutputPage.php line 2961:
Call to undefined method OutputPage::getLang()
Modified paths:
  • /branches/REL1_18/phase3/includes/OutputPage.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/includes/OutputPage.php
——@@ -2958,7 +2958,8 @@
29592959 * @param $flip Boolean: Whether to flip the CSS if needed
29602960 */
29612961 public function addInlineStyle( $style_css, $flip = false ) {
2962 - if( $flip && $this->getLang()->isRTL() ) {
 2962+ global $wgLang;
 2963+ if( $flip && $wgLang->isRTL() ) {
29632964 # If wanted, and the interface is right-to-left, flip the CSS
29642965 $style_css = CSSJanus::transform( $style_css, true, false );
29652966 }
Index: branches/REL1_18/phase3/includes/OutputPage.php
——@@ -2958,7 +2958,8 @@
29592959 * @param $flip Boolean: Whether to flip the CSS if needed
29602960 */
29612961 public function addInlineStyle( $style_css, $flip = false ) {
2962 - if( $flip && $this->getLang()->isRTL() ) {
 2962+ global $wgLang;
 2963+ if( $flip && $wgLang->isRTL() ) {
29632964 # If wanted, and the interface is right-to-left, flip the CSS
29642965 $style_css = CSSJanus::transform( $style_css, true, false );
29652966 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r97624MFT r93557, revert r97588 in 1.18wmf1 AND REL1_18reedy13:23, 20 September 2011

Status & tagging log