r97405 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97404‎ | r97405 | r97406 >
Date:04:58, 18 September 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Add extra unit test in Transformation for mediawiki.Title
* (bug 30843) mediawiki.Title should not convert extensions (anything after the last full stop) to lower case
* Patch my Michael M. slightly modified (moved to section "Transformation")
* Currently broken, will fix in next commit
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.Title.test.js
——@@ -64,7 +64,7 @@
6565 });
6666
6767 test( 'Transformation', function() {
68 - expect(3);
 68+ expect(4);
6969 _titleConfig();
7070
7171 var title;
——@@ -75,6 +75,9 @@
7676 title = new mw.Title( 'File:Glarg_foo_glang.jpg' );
7777 equal( title.getNameText(), 'Glarg foo glang' );
7878
 79+ title = new mw.Title( 'User:ABC.DEF' );
 80+ equal( title.toText(), 'User:ABC.DEF' );
 81+
7982 title = new mw.Title( ' MediaWiki: Foo bar .js ' );
8083 // Don't ask why, it's the way the backend works. One space is kept of each set
8184 equal( title.getName(), 'Foo_bar_.js', "Merge multiple spaces to a single space." );

Follow-up revisions

RevisionCommit summaryAuthorDate
r97406Fix lowercase test added in r97405...krinkle05:03, 18 September 2011
r97407Release-notes for bug 30843 / r97405 / r97406krinkle05:05, 18 September 2011

Comments

#Comment by Catrope (talk | contribs)   11:29, 18 September 2011

Untagging 1.18: target file does not exist in REL1_18.

#Comment by Krinkle (talk | contribs)   12:59, 18 September 2011

Oh, not just the test suite. Neither does the main 'mediawiki.Title' module exist in 1.18. Sorry, my bad :)

Status & tagging log