r97207 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97206‎ | r97207 | r97208 >
Date:21:22, 15 September 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
RevisionDeleter::getChanges() documentation cleanup
Modified paths:
  • /trunk/phase3/includes/revisiondelete/RevisionDeleter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/revisiondelete/RevisionDeleter.php
@@ -28,12 +28,14 @@
2929 }
3030
3131 /**
32 - * Gets an array of message keys describing the changes made to the visibility
33 - * of the revision. If the resulting array is $arr, then $arr[0] will contain an
34 - * array of strings describing the items that were hidden, $arr[1] will contain
35 - * an array of strings describing the items that were unhidden, and $arr[2] will
36 - * contain an array with a single string, which can be one of "applied
37 - * restrictions to sysops", "removed restrictions from sysops", or null.
 32+ * Gets an array of message keys describing the changes made to the
 33+ * visibility of the revision.
 34+ *
 35+ * If the resulting array is $arr, then $arr[0] will contain an array of
 36+ * message keys describing the items that were hidden, $arr[1] will contain
 37+ * an array of message keys describing the items that were unhidden, and $arr[2]
 38+ * will contain an array with a single message key, which can be one of
 39+ * "revdelete-restricted", "revdelete-unrestricted", or null, indicating (un)suppression.
3840 *
3941 * @param $n Integer: the new bitfield.
4042 * @param $o Integer: the old bitfield.

Follow-up revisions

RevisionCommit summaryAuthorDate
r97239* Fixed indentation...nikerabbit06:15, 16 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   05:09, 16 September 2011

It doesn't return message keys anymore, because I added foo-hid and foo-unhid variants. Tabs would be nice. Why does null indicate suppression? I've only seen stuff in the third array with some suppression log messages.

#Comment by Aaron Schulz (talk | contribs)   05:28, 16 September 2011

I mean the third item indicates (un)suppression. Null indicates neither.

#Comment by Aaron Schulz (talk | contribs)   05:33, 16 September 2011

Also, please update the docs according to any changes you made (to the third arg).

#Comment by Nikerabbit (talk | contribs)   06:01, 16 September 2011

I didn't change anything about third arg.

Status & tagging log