r97239 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97238‎ | r97239 | r97240 >
Date:06:15, 16 September 2011
Author:nikerabbit
Status:resolved (Comments)
Tags:
Comment:
* Fixed indentation
* Fixed assumption about message keys that was no longer true
* Ping r97207
* Clarified the part about null
Modified paths:
  • /trunk/phase3/includes/revisiondelete/RevisionDeleter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/revisiondelete/RevisionDeleter.php
@@ -29,14 +29,17 @@
3030
3131 /**
3232 * Gets an array of message keys describing the changes made to the
33 - * visibility of the revision.
34 - *
35 - * If the resulting array is $arr, then $arr[0] will contain an array of
36 - * message keys describing the items that were hidden, $arr[1] will contain
37 - * an array of message keys describing the items that were unhidden, and $arr[2]
38 - * will contain an array with a single message key, which can be one of
39 - * "revdelete-restricted", "revdelete-unrestricted", or null, indicating (un)suppression.
 33+ * visibility of the revision.
4034 *
 35+ * If the resulting array is $arr, then $arr[0] will contain an array of
 36+ * keys describing the items that were hidden, $arr[1] will contain
 37+ * an array of keys describing the items that were unhidden, and $arr[2]
 38+ * will contain an array with a single message key, which can be one of
 39+ * "revdelete-restricted", "revdelete-unrestricted" indicating (un)suppression
 40+ * or null to indicate nothing in particular.
 41+ * You can turn the keys in 0 and 1 into message keys by appendin -hid and
 42+ * and -unhid to they keys respectively.
 43+ *
4144 * @param $n Integer: the new bitfield.
4245 * @param $o Integer: the old bitfield.
4346 * @return An array as described above.

Follow-up revisions

RevisionCommit summaryAuthorDate
r97240Improve r97239 with comments from Aaron. Also fixed another typo that was lur...nikerabbit06:23, 16 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97207RevisionDeleter::getChanges() documentation cleanupaaron21:22, 15 September 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   06:19, 16 September 2011

Maybe 'keys in 0 and 1' could read 'keys in $arr[0] and $arr[1]'.

Also, typo in 'they keys respectively' :)

Status & tagging log