r97082 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97081‎ | r97082 | r97083 >
Date:18:11, 14 September 2011
Author:dantman
Status:ok
Tags:
Comment:
Merged revisions 97057,97060,97071,97073-97074,97077-97080 via svnmerge from
svn+ssh://dantman@wikimedia/svnroot/mediawiki/trunk/phase3

........
r97057 | catrope | 2011-09-14 06:43:06 -0700 (Wed, 14 Sep 2011) | 2 lines

Revert r96715 per committer's (Chad's) CR comment
........
r97060 | reedy | 2011-09-14 08:07:20 -0700 (Wed, 14 Sep 2011) | 1 line

Whitespace/documentation
........
r97071 | catrope | 2011-09-14 09:48:29 -0700 (Wed, 14 Sep 2011) | 2 lines

Introduce Language::getMessageKeysFor() and use it in ApiQueryAllmessages
........
r97073 | aaron | 2011-09-14 10:15:07 -0700 (Wed, 14 Sep 2011) | 1 line

Added @todo items
........
r97074 | raindrift | 2011-09-14 10:23:09 -0700 (Wed, 14 Sep 2011) | 3 lines

Fixed incorrect userId reference
........
r97077 | aaron | 2011-09-14 10:42:28 -0700 (Wed, 14 Sep 2011) | 1 line

FU r97022: Fallback to empty array for getExtraSortFields() result in __construct() if no value is set for the sort order/type.
........
r97078 | raindrift | 2011-09-14 10:48:10 -0700 (Wed, 14 Sep 2011) | 4 lines

Switched from prepending http for protocol-relative $wgUploadStashScalerBaseUrl to wfExpandUrl()
Followup to r96934
........
r97079 | aaron | 2011-09-14 10:51:37 -0700 (Wed, 14 Sep 2011) | 1 line

Fixed WikiPage::newFromId to use the factory() function
........
r97080 | nikerabbit | 2011-09-14 11:02:04 -0700 (Wed, 14 Sep 2011) | 2 lines

Fix typo in r97044 reported in twn
........
Modified paths:
  • /branches/pageoutput (modified) (history)
  • /branches/pageoutput/api.php (modified) (history)
  • /branches/pageoutput/includes (modified) (history)
  • /branches/pageoutput/includes/AutoLoader.php (modified) (history)
  • /branches/pageoutput/includes/CategoryPage.php (modified) (history)
  • /branches/pageoutput/includes/ChangesList.php (modified) (history)
  • /branches/pageoutput/includes/ConfEditor.php (modified) (history)
  • /branches/pageoutput/includes/GlobalFunctions.php (modified) (history)
  • /branches/pageoutput/includes/HistoryPage.php (modified) (history)
  • /branches/pageoutput/includes/Message.php (modified) (history)
  • /branches/pageoutput/includes/OutputPage.php (modified) (history)
  • /branches/pageoutput/includes/Pager.php (modified) (history)
  • /branches/pageoutput/includes/Revision.php (modified) (history)
  • /branches/pageoutput/includes/SpecialPage.php (modified) (history)
  • /branches/pageoutput/includes/SpecialPageFactory.php (modified) (history)
  • /branches/pageoutput/includes/Title.php (modified) (history)
  • /branches/pageoutput/includes/WikiCategoryPage.php (modified) (history)
  • /branches/pageoutput/includes/WikiFilePage.php (modified) (history)
  • /branches/pageoutput/includes/WikiPage.php (modified) (history)
  • /branches/pageoutput/includes/api (modified) (history)
  • /branches/pageoutput/includes/api/ApiQueryAllmessages.php (modified) (history)
  • /branches/pageoutput/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /branches/pageoutput/includes/api/ApiUpload.php (modified) (history)
  • /branches/pageoutput/includes/cache/MessageCache.php (modified) (history)
  • /branches/pageoutput/includes/db/Database.php (modified) (history)
  • /branches/pageoutput/includes/db/DatabaseError.php (modified) (history)
  • /branches/pageoutput/includes/db/DatabaseUtility.php (modified) (history)
  • /branches/pageoutput/includes/db/LoadBalancer.php (modified) (history)
  • /branches/pageoutput/includes/filerepo/File.php (modified) (history)
  • /branches/pageoutput/includes/installer/DatabaseInstaller.php (modified) (history)
  • /branches/pageoutput/includes/interwiki/Interwiki.php (modified) (history)
  • /branches/pageoutput/includes/json/Services_JSON.php (modified) (history)
  • /branches/pageoutput/includes/libs/HttpStatus.php (modified) (history)
  • /branches/pageoutput/includes/media/Exif.php (modified) (history)
  • /branches/pageoutput/includes/media/ExifBitmap.php (modified) (history)
  • /branches/pageoutput/includes/parser/Parser.php (modified) (history)
  • /branches/pageoutput/includes/resourceloader/ResourceLoader.php (modified) (history)
  • /branches/pageoutput/includes/specials (modified) (history)
  • /branches/pageoutput/includes/specials/SpecialAllmessages.php (modified) (history)
  • /branches/pageoutput/includes/specials/SpecialBlock.php (modified) (history)
  • /branches/pageoutput/includes/specials/SpecialUploadStash.php (modified) (history)
  • /branches/pageoutput/includes/upload/UploadBase.php (modified) (history)
  • /branches/pageoutput/includes/upload/UploadFromFile.php (modified) (history)
  • /branches/pageoutput/includes/upload/UploadStash.php (modified) (history)
  • /branches/pageoutput/languages (modified) (history)
  • /branches/pageoutput/languages/Language.php (modified) (history)
  • /branches/pageoutput/languages/messages/MessagesEn.php (modified) (history)
  • /branches/pageoutput/maintenance/archives (modified) (history)
  • /branches/pageoutput/maintenance/cleanupTable.inc (modified) (history)
  • /branches/pageoutput/maintenance/deleteSelfExternals.php (modified) (history)
  • /branches/pageoutput/maintenance/findHooks.php (modified) (history)
  • /branches/pageoutput/maintenance/mergeMessageFileList.php (modified) (history)
  • /branches/pageoutput/maintenance/populateRevisionLength.php (modified) (history)
  • /branches/pageoutput/maintenance/tables.sql (modified) (history)
  • /branches/pageoutput/tests/parserTests.php (modified) (history)
  • /branches/pageoutput/tests/phpunit/Makefile (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/1bit-png.png (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/Animated_PNG_example_bouncing_beach_ball.png (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/Gtk-media-play-ltr.svg (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/Png-native-test.png (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/QA_icon.svg (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/README (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/US_states_by_total_state_tax_revenue.svg (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/Wikimedia-logo.svg (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/Xmp-exif-multilingual_test.jpg (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/broken_exif_date.jpg (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/greyscale-na-png.png (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/greyscale-png.png (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/landscape-plain.jpg (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/portrait-rotated.jpg (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/rgb-na-png.png (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/rgb-png.png (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/test.jpg (modified) (history)
  • /branches/pageoutput/tests/phpunit/data/media/test.tiff (modified) (history)
  • /branches/pageoutput/tests/phpunit/includes/MessageTest.php (modified) (history)
  • /branches/pageoutput/tests/phpunit/includes/api/ApiUploadTest.php (modified) (history)
  • /branches/pageoutput/tests/phpunit/includes/api/RandomImageGenerator.php (modified) (history)
  • /branches/pageoutput/tests/phpunit/includes/api/generateRandomImages.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiButtonsAvailabilityTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiDifferentDatabaseAccountTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiDifferntDatabasePrefixTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiErrorsConnectToDatabasePageTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiErrorsNamepageTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiHelpFieldHintTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiInstallationCommonFunction.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiInstallationConfig.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiInstallationMessage.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiInstallationVariables.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiInstallerTestSuite.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiMySQLDataBaseTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiMySQLiteDataBaseTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiOnAlreadyInstalledTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiRestartInstallationTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiRightFrameworkLinksTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiUpgradeExistingDatabaseTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/MediaWikiUserInterfaceTestCase.php (modified) (history)
  • /branches/pageoutput/tests/selenium/installer/README.txt (modified) (history)
  • /branches/pageoutput/tests/testHelpers.inc (modified) (history)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96715Add a comment about something I noticed while spelunking the codedemon06:47, 10 September 2011
r96934If the scaler URL is protocol-relative, things just break here. Sets a sane ...raindrift00:53, 13 September 2011
r97022Possible fix for issue reported in r83762. I had a hard time confirming the p...aaron23:24, 13 September 2011
r97044RevisionDeleter:...nikerabbit10:36, 14 September 2011
r97057Revert r96715 per committer's (Chad's) CR commentcatrope13:43, 14 September 2011
r97060Whitespace/documentationreedy15:07, 14 September 2011
r97071Introduce Language::getMessageKeysFor() and use it in ApiQueryAllmessagescatrope16:48, 14 September 2011
r97073Added @todo itemsaaron17:15, 14 September 2011
r97074Fixed incorrect userId referenceraindrift17:23, 14 September 2011
r97077FU r97022: Fallback to empty array for getExtraSortFields() result in __const...aaron17:42, 14 September 2011
r97078Switched from prepending http for protocol-relative $wgUploadStashScalerBaseU...raindrift17:48, 14 September 2011
r97079Fixed WikiPage::newFromId to use the factory() functionaaron17:51, 14 September 2011
r97080Fix typo in r97044 reported in twnnikerabbit18:02, 14 September 2011

Status & tagging log