r83762 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83761‎ | r83762 | r83763 >
Date:15:16, 12 March 2011
Author:midom
Status:ok (Comments)
Tags:live 
Comment:
different GROUP BY and ORDER BY will result in a temptable of a full resultset yay
Modified paths:
  • /branches/wmf/1.17wmf1/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/extensions/FlaggedRevs/specialpages/ProblemChanges_body.php
——@@ -328,7 +328,7 @@
329329 }
330330 array_unshift( $tables, 'flaggedpages' ); // order matters
331331 $this->mIndexField = 'fp_pending_since';
332 - $groupBy = 'fp_pending_since,fp_page_id';
 332+ $groupBy = 'fp_pending_since';
333333 # Show outdated pages for a specific review level
334334 } else {
335335 $fields[] = 'fpp_rev_id AS stable';
——@@ -354,7 +354,7 @@
355355 }
356356 array_unshift( $tables, 'flaggedpage_pending' ); // order matters
357357 $this->mIndexField = 'fpp_pending_since';
358 - $groupBy = 'fpp_pending_since,fpp_page_id';
 358+ $groupBy = 'fpp_pending_since';
359359 }
360360 $fields[] = $this->mIndexField; // Pager needs this
361361 $conds['page_namespace'] = $this->namespace; // sanity check NS

Follow-up revisions

RevisionCommit summaryAuthorDate
r97022Possible fix for issue reported in r83762. I had a hard time confirming the p...aaron23:24, 13 September 2011

Comments

#Comment by Midom (talk | contribs)   15:20, 12 March 2011

there're 330 "doubles" out of 100k.

though it may be possible to add an index for this, for now this doesn't cause too much harm (and I've sent it live)

#Comment by Aaron Schulz (talk | contribs)   18:05, 8 May 2011

Looking at this some more today. No temporary tables show up in EXPLAIN (on cluster or on me test wiki).

Status & tagging log