r97044 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97043‎ | r97044 | r97045 >
Date:10:36, 14 September 2011
Author:nikerabbit
Status:resolved (Comments)
Tags:
Comment:
RevisionDeleter:
* Fixed comment of getChanges and made it public
* Removed getLogMessage and expandMessageArray, now unused
LogFormatter:
* Cache parsed parameters locally, since this function is going to be called few times for every log entry
DefaultSettings:
* Could not find any use of suppress/file log
LogPage:
* Removed old formatting code, now unused
WikiPage:
* Converted (suppress|delete)/delete logs to new format

Added DeleteLogFormatter, handles part of suppression log as well.
Updated messages.
This also addresses bug 18578.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/LogPage.php (modified) (history)
  • /trunk/phase3/includes/WikiPage.php (modified) (history)
  • /trunk/phase3/includes/logging/LogFormatter.php (modified) (history)
  • /trunk/phase3/includes/revisiondelete/RevisionDeleter.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFi.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -768,10 +768,6 @@
769769 'revdelete-unsuppress',
770770 'revdelete-log',
771771 'revdelete-submit',
772 - 'revdelete-logentry',
773 - 'logdelete-logentry',
774 - 'revdelete-logaction',
775 - 'logdelete-logaction',
776772 'revdelete-success',
777773 'revdelete-failure',
778774 'logdelete-success',
@@ -781,15 +777,6 @@
782778 'revdel-restore-visible',
783779 'pagehist',
784780 'deletedhist',
785 - 'revdelete-content',
786 - 'revdelete-summary',
787 - 'revdelete-uname',
788 - 'revdelete-restricted',
789 - 'revdelete-unrestricted',
790 - 'revdelete-hid',
791 - 'revdelete-unhid',
792 - 'revdelete-log-message',
793 - 'logdelete-log-message',
794781 'revdelete-hide-current',
795782 'revdelete-show-no-access',
796783 'revdelete-modify-no-access',
@@ -1870,8 +1857,6 @@
18711858 'actioncomplete',
18721859 'actionfailed',
18731860 'deletedtext',
1874 - 'deletedarticle',
1875 - 'suppressedarticle',
18761861 'dellogpage',
18771862 'dellogpagetext',
18781863 'deletionlog',
@@ -1977,7 +1962,6 @@
19781963 'undeletereset',
19791964 'undeleteinvert',
19801965 'undeletecomment',
1981 - 'undeletedarticle',
19821966 'undeletedrevisions',
19831967 'undeletedrevisions-files',
19841968 'undeletedfiles',
@@ -3513,6 +3497,25 @@
35143498 'confirm-unwatch-button',
35153499 ),
35163500 'logging' => array(
 3501+ 'logentry-delete-delete',
 3502+ 'logentry-delete-restore',
 3503+ 'logentry-delete-event',
 3504+ 'logentry-delete-revision',
 3505+ 'logentry-delete-event-legacy',
 3506+ 'logentry-delete-revision-legacy',
 3507+ 'logentry-suppress-delete',
 3508+ 'logentry-suppress-event',
 3509+ 'logentry-suppress-revision',
 3510+ 'logentry-suppress-event-legacy',
 3511+ 'logentry-suppress-revision-legacy',
 3512+ 'revdelete-content-hid',
 3513+ 'revdelete-summary-hid',
 3514+ 'revdelete-uname-hid',
 3515+ 'revdelete-content-unhid',
 3516+ 'revdelete-summary-unhid',
 3517+ 'revdelete-uname-unhid',
 3518+ 'revdelete-restricted',
 3519+ 'revdelete-unrestricted',
35173520 'logentry-move-move',
35183521 'logentry-move-move-noredirect',
35193522 'logentry-move-move_redir',
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -61,6 +61,8 @@
6262 to stop it from replace an already existing default sort, and suppress error.
6363 * (bug 30364) LanguageConverter now depends on the page content language
6464 instead of the wiki content language
 65+* (bug 18578) Rewrote revision delete related messages to allow better
 66+ localisation
6567
6668 === Bug fixes in 1.19 ===
6769 * $wgUploadNavigationUrl should be used for file redlinks if
Index: trunk/phase3/includes/revisiondelete/RevisionDeleter.php
@@ -30,16 +30,17 @@
3131 /**
3232 * Gets an array of message keys describing the changes made to the visibility
3333 * of the revision. If the resulting array is $arr, then $arr[0] will contain an
34 - * array of strings describing the items that were hidden, $arr[2] will contain
35 - * an array of strings describing the items that were unhidden, and $arr[3] will
 34+ * array of strings describing the items that were hidden, $arr[1] will contain
 35+ * an array of strings describing the items that were unhidden, and $arr[2] will
3636 * contain an array with a single string, which can be one of "applied
3737 * restrictions to sysops", "removed restrictions from sysops", or null.
3838 *
3939 * @param $n Integer: the new bitfield.
4040 * @param $o Integer: the old bitfield.
4141 * @return An array as described above.
 42+ * @since 1.19 public
4243 */
43 - protected static function getChanges( $n, $o ) {
 44+ public static function getChanges( $n, $o ) {
4445 $diff = $n ^ $o;
4546 $ret = array( 0 => array(), 1 => array(), 2 => array() );
4647 // Build bitfield changes in language
@@ -59,47 +60,6 @@
6061 return $ret;
6162 }
6263
63 - /**
64 - * Gets a log message to describe the given revision visibility change. This
65 - * message will be of the form "[hid {content, edit summary, username}];
66 - * [unhid {...}][applied restrictions to sysops] for $count revisions: $comment".
67 - *
68 - * @param $count Integer: The number of effected revisions.
69 - * @param $nbitfield Integer: The new bitfield for the revision.
70 - * @param $obitfield Integer: The old bitfield for the revision.
71 - * @param $language Language object to use
72 - * @param $isForLog Boolean
73 - */
74 - public static function getLogMessage( $count, $nbitfield, $obitfield, $language, $isForLog = false ) {
75 - $changes = self::getChanges( $nbitfield, $obitfield );
76 - array_walk( $changes, array( __CLASS__, 'expandMessageArray' ), $language );
77 -
78 - $changesText = array();
79 -
80 - if( count( $changes[0] ) ) {
81 - $changesText[] = wfMsgExt( 'revdelete-hid', array( 'parsemag', 'language' => $language ), $language->commaList( $changes[0] ) );
82 - }
83 - if( count( $changes[1] ) ) {
84 - $changesText[] = wfMsgExt( 'revdelete-unhid', array( 'parsemag', 'language' => $language ), $language->commaList( $changes[1] ) );
85 - }
86 -
87 - $s = $language->semicolonList( $changesText );
88 - if( count( $changes[2] ) ) {
89 - $s .= $s ? ' (' . $changes[2][0] . ')' : ' ' . $changes[2][0];
90 - }
91 -
92 - $msg = $isForLog ? 'logdelete-log-message' : 'revdelete-log-message';
93 - return wfMsgExt( $msg, array( 'parsemag', 'language' => $language ), $s, $language->formatNum($count) );
94 - }
95 -
96 - private static function expandMessageArray( &$msg, $key, $language ) {
97 - if ( is_array ( $msg ) ) {
98 - array_walk( $msg, array( __CLASS__, 'expandMessageArray' ), $language );
99 - } else {
100 - $msg = wfMsgExt( $msg, array( 'parsemag', 'language' => $language ) );
101 - }
102 - }
103 -
10464 // Get DB field name for URL param...
10565 // Future code for other things may also track
10666 // other types of revision-specific changes.
Index: trunk/phase3/includes/logging/LogFormatter.php
@@ -133,7 +133,7 @@
134134 * @return Message|pre-escaped html
135135 */
136136 protected function getActionMessage() {
137 - $message = $this->msg( $this->getMessageKey() );
 137+ $message = $this->msg( $this->getMessageKey() );
138138 $message->params( $this->getMessageParameters() );
139139 return $message;
140140 }
@@ -162,6 +162,10 @@
163163 * @return array
164164 */
165165 protected function getMessageParameters() {
 166+ if ( isset( $this->parsedParameters ) ) {
 167+ return $this->parsedParameters;
 168+ }
 169+
166170 $entry = $this->entry;
167171
168172 $params = array();
@@ -193,7 +197,7 @@
194198 }
195199 }
196200
197 - return $params;
 201+ return $this->parsedParameters = $params;
198202 }
199203
200204 /**
@@ -341,3 +345,69 @@
342346 return $params;
343347 }
344348 }
 349+
 350+/**
 351+ * This class formats delete log entries.
 352+ * @since 1.19
 353+ */
 354+class DeleteLogFormatter extends LogFormatter {
 355+ protected function getMessageKey() {
 356+ $key = parent::getMessageKey();
 357+ if ( in_array( $this->entry->getSubtype(), array( 'event', 'revision' ) ) ) {
 358+ if ( count( $this->getMessageParameters() ) < 5 ) {
 359+ return "$key-legacy";
 360+ }
 361+ }
 362+ return $key;
 363+ }
 364+
 365+ protected function getMessageParameters() {
 366+ if ( isset( $this->parsedParametersDeleteLog ) ) {
 367+ return $this->parsedParametersDeleteLog;
 368+ }
 369+
 370+ $params = parent::getMessageParameters();
 371+ $subtype = $this->entry->getSubtype();
 372+ if ( in_array( $subtype, array( 'event', 'revision' ) ) ) {
 373+ if ( count( $params ) > 5 ) {
 374+ $paramStart = $subtype === 'revision' ? 4 : 3;
 375+
 376+ $old = $this->parseBitField( $params[$paramStart+1] );
 377+ $new = $this->parseBitField( $params[$paramStart+2] );
 378+ list( $hid, $unhid, $extra ) = RevisionDeleter::getChanges( $new, $old );
 379+ $changes = array();
 380+ foreach ( $hid as $v ) {
 381+ $changes[] = $this->msg( "$v-hid" )->plain();
 382+ }
 383+ foreach ( $unhid as $v ) {
 384+ $changes[] = $this->msg( "$v-unhid" )->plain();
 385+ }
 386+ foreach ( $extra as $v ) {
 387+ $changes[] = $this->msg( $v )->plain();
 388+ }
 389+ $changeText = $this->context->getLang()->listToText( $changes );
 390+
 391+
 392+ $newParams = array_slice( $params, 0, 3 );
 393+ $newParams[3] = $changeText;
 394+ $count = count( explode( ',', $params[$paramStart] ) );
 395+ $newParams[4] = $this->context->getLang()->formatNum( $count );
 396+ return $this->parsedParametersDeleteLog = $newParams;
 397+ } else {
 398+ return $this->parsedParametersDeleteLog = array_slice( $params, 0, 3 );
 399+ }
 400+ }
 401+
 402+ return $this->parsedParametersDeleteLog = $params;
 403+ }
 404+
 405+ protected function parseBitField( $string ) {
 406+ // Input is like ofield=2134 or just the number
 407+ if ( strpos( $string, 'field=' ) === 1 ) {
 408+ list( , $field ) = explode( '=', $string );
 409+ return (int) $field;
 410+ } else {
 411+ return (int) $string;
 412+ }
 413+ }
 414+}
Index: trunk/phase3/includes/AutoLoader.php
@@ -542,6 +542,7 @@
543543 'ManualLogEntry' => 'includes/logging/LogEntry.php',
544544 'LogFormatter' => 'includes/logging/LogFormatter.php',
545545 'LegacyLogFormatter' => 'includes/logging/LogFormatter.php',
 546+ 'DeleteLogFormatter' => 'includes/logging/LogFormatter.php',
546547 'MoveLogFormatter' => 'includes/logging/LogFormatter.php',
547548
548549 # includes/media
Index: trunk/phase3/includes/WikiPage.php
@@ -1741,10 +1741,13 @@
17421742
17431743 # Log the deletion, if the page was suppressed, log it at Oversight instead
17441744 $logtype = $suppress ? 'suppress' : 'delete';
1745 - $log = new LogPage( $logtype );
17461745
1747 - # Make sure logging got through
1748 - $log->addEntry( 'delete', $this->mTitle, $reason, array() );
 1746+ $logEntry = new ManualLogEntry( $logtype, 'delete' );
 1747+ $logEntry->setPerformer( $user );
 1748+ $logEntry->setTarget( $this->mTitle );
 1749+ $logEntry->setComment( $reason );
 1750+ $logid = $logEntry->insert();
 1751+ $logEntry->publish( $logid );
17491752
17501753 if ( $commit ) {
17511754 $dbw->commit();
Index: trunk/phase3/includes/DefaultSettings.php
@@ -5028,20 +5028,12 @@
50295029 'protect/move_prot' => 'movedarticleprotection',
50305030 'rights/rights' => 'rightslogentry',
50315031 'rights/autopromote' => 'rightslogentry-autopromote',
5032 - 'delete/delete' => 'deletedarticle',
5033 - 'delete/restore' => 'undeletedarticle',
5034 - 'delete/revision' => 'revdelete-logentry',
5035 - 'delete/event' => 'logdelete-logentry',
50365032 'upload/upload' => 'uploadedimage',
50375033 'upload/overwrite' => 'overwroteimage',
50385034 'upload/revert' => 'uploadedimage',
50395035 'import/upload' => 'import-logentry-upload',
50405036 'import/interwiki' => 'import-logentry-interwiki',
50415037 'merge/merge' => 'pagemerge-logentry',
5042 - 'suppress/revision' => 'revdelete-logentry',
5043 - 'suppress/file' => 'revdelete-logentry',
5044 - 'suppress/event' => 'logdelete-logentry',
5045 - 'suppress/delete' => 'suppressedarticle',
50465038 'suppress/block' => 'blocklogentry',
50475039 'suppress/reblock' => 'reblock-logentry',
50485040 'patrol/patrol' => 'patrol-log-line',
@@ -5055,7 +5047,12 @@
50565048 */
50575049 $wgLogActionsHandlers = array(
50585050 // move, move_redir
5059 - 'move/*' => 'MoveLogFormatter',
 5051+ 'move/*' => 'MoveLogFormatter',
 5052+ // delete, restore, revision, event
 5053+ 'delete/*' => 'DeleteLogFormatter',
 5054+ 'suppress/revision' => 'DeleteLogFormatter',
 5055+ 'suppress/event' => 'DeleteLogFormatter',
 5056+ 'suppress/delete' => 'DeleteLogFormatter',
50605057 );
50615058
50625059 /**
Index: trunk/phase3/includes/LogPage.php
@@ -286,23 +286,6 @@
287287 if( $params[2] ) {
288288 $details .= ' [' . wfMsgExt( 'protect-summary-cascade', array( 'parsemag', 'language' => $langObj ) ) . ']';
289289 }
290 - // Page moves
291 - } elseif ( $type == 'move' && count( $params ) == 3 ) {
292 - if( $params[2] ) {
293 - $details .= ' [' . wfMsgExt( 'move-redirect-suppressed', array( 'parsemag', 'language' => $langObj ) ) . ']';
294 - }
295 - // Revision deletion
296 - } elseif ( preg_match( '/^(delete|suppress)\/revision$/', $key ) && count( $params ) == 5 ) {
297 - $count = substr_count( $params[2], ',' ) + 1; // revisions
298 - $ofield = intval( substr( $params[3], 7 ) ); // <ofield=x>
299 - $nfield = intval( substr( $params[4], 7 ) ); // <nfield=x>
300 - $details .= ': ' . RevisionDeleter::getLogMessage( $count, $nfield, $ofield, $langObj, false );
301 - // Log deletion
302 - } elseif ( preg_match( '/^(delete|suppress)\/event$/', $key ) && count( $params ) == 4 ) {
303 - $count = substr_count( $params[1], ',' ) + 1; // log items
304 - $ofield = intval( substr( $params[2], 7 ) ); // <ofield=x>
305 - $nfield = intval( substr( $params[3], 7 ) ); // <nfield=x>
306 - $details .= ': ' . RevisionDeleter::getLogMessage( $count, $nfield, $ofield, $langObj, true );
307290 }
308291
309292 $rv = wfMsgExt( $wgLogActions[$key], array( 'parsemag', 'escape', 'replaceafter', 'language' => $langObj ), $params ) . $details;
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1572,8 +1572,6 @@
15731573 'revdelete-unsuppress' => 'Remove restrictions on restored revisions',
15741574 'revdelete-log' => 'Reason:',
15751575 'revdelete-submit' => 'Apply to selected {{PLURAL:$1|revision|revisions}}',
1576 -'revdelete-logentry' => 'changed revision visibility of "[[$1]]"',
1577 -'logdelete-logentry' => 'changed event visibility of "[[$1]]"',
15781576 'revdelete-success' => "'''Revision visibility successfully updated.'''",
15791577 'revdelete-failure' => "'''Revision visibility could not be updated:'''
15801578 $1",
@@ -1585,15 +1583,6 @@
15861584 'revdel-restore-visible' => 'visible revisions',
15871585 'pagehist' => 'Page history',
15881586 'deletedhist' => 'Deleted history',
1589 -'revdelete-content' => 'content',
1590 -'revdelete-summary' => 'edit summary',
1591 -'revdelete-uname' => 'username',
1592 -'revdelete-restricted' => 'applied restrictions to administrators',
1593 -'revdelete-unrestricted' => 'removed restrictions for administrators',
1594 -'revdelete-hid' => 'hid $1',
1595 -'revdelete-unhid' => 'unhid $1',
1596 -'revdelete-log-message' => '$1 for $2 {{PLURAL:$2|revision|revisions}}',
1597 -'logdelete-log-message' => '$1 for $2 {{PLURAL:$2|event|events}}',
15981587 'revdelete-hide-current' => 'Error hiding the item dated $2, $1: this is the current revision.
15991588 It cannot be hidden.',
16001589 'revdelete-show-no-access' => 'Error showing the item dated $2, $1: this item has been marked "restricted".
@@ -2810,8 +2799,6 @@
28112800 'actionfailed' => 'Action failed',
28122801 'deletedtext' => '"$1" has been deleted.
28132802 See $2 for a record of recent deletions.',
2814 -'deletedarticle' => 'deleted "[[$1]]"',
2815 -'suppressedarticle' => 'suppressed "[[$1]]"',
28162803 'dellogpage' => 'Deletion log',
28172804 'dellogpagetext' => 'Below is a list of the most recent deletions.',
28182805 'deletionlog' => 'deletion log',
@@ -2946,7 +2933,6 @@
29472934 'undeletereset' => 'Reset',
29482935 'undeleteinvert' => 'Invert selection',
29492936 'undeletecomment' => 'Reason:',
2950 -'undeletedarticle' => 'restored "[[$1]]"',
29512937 'undeletedrevisions' => '{{PLURAL:$1|1 revision|$1 revisions}} restored',
29522938 'undeletedrevisions-files' => '{{PLURAL:$1|1 revision|$1 revisions}} and {{PLURAL:$2|1 file|$2 files}} restored',
29532939 'undeletedfiles' => '{{PLURAL:$1|1 file|$1 files}} restored',
@@ -4647,6 +4633,25 @@
46484634 'sqlite-no-fts' => '$1 without full-text search support',
46494635
46504636 # New logging system
 4637+'logentry-delete-delete' => '$1 {{GENDER:$2|deleted}} page $3',
 4638+'logentry-delete-restore' => '$1 {{GENDER:$2|restored}} page $3',
 4639+'logentry-delete-event' => '$1 {{GENDER:$2|changed}} visibility of {{PLURAL:$5|a log event|$5 log events}} on $3: $4',
 4640+'logentry-delete-revision' => '$1 {{GENDER:$2|changed}} visibility of {{PLURAL:$5|a revision|$5 revisions}} on page $3: $4',
 4641+'logentry-delete-event-legacy' => '$1 {{GENDER:$2|changed}} visibility of log events on $3',
 4642+'logentry-delete-revision-legacy' => '$1 {{GENDER:$2|changed}} visibility of revisions on page $3',
 4643+'logentry-suppress-delete' => '$1 {{GENDER:$2|supressed}} page $3',
 4644+'logentry-suppress-event' => '$1 secretly {{GENDER:$2|changed}} visibility of {{PLURAL:$5|a log event|$5 log events}} on $3: $4',
 4645+'logentry-suppress-revision' => '$1 secretly {{GENDER:$2|changed}} visibility of {{PLURAL:$5|a revision|$5 revisions}} on page $3: $4',
 4646+'logentry-suppress-event-legacy' => '$1 secretly {{GENDER:$2|changed}} visibility of log events on $3',
 4647+'logentry-suppress-revision-legacy' => '$1 secretly {{GENDER:$2|changed}} visibility of revisions on page $3',
 4648+'revdelete-content-hid' => 'content hidden',
 4649+'revdelete-summary-hid' => 'edit summary hidden',
 4650+'revdelete-uname-hid' => 'username hidden',
 4651+'revdelete-content-unhid' => 'content unhidden',
 4652+'revdelete-summary-unhid' => 'edit summary unhidden',
 4653+'revdelete-uname-unhid' => 'username unhidden',
 4654+'revdelete-restricted' => 'applied restrictions to administrators',
 4655+'revdelete-unrestricted' => 'removed restrictions for administrators',
46514656 'logentry-move-move' => '$1 {{GENDER:$2|moved}} page $3 to $4',
46524657 'logentry-move-move-noredirect' => '$1 {{GENDER:$2|moved}} page $3 to $4 without leaving a redirect',
46534658 'logentry-move-move_redir' => '$1 {{GENDER:$2|moved}} page $3 to $4 over redirect',
Index: trunk/phase3/languages/messages/MessagesFi.php
@@ -1136,8 +1136,6 @@
11371137 'revdelete-unsuppress' => 'Poista rajoitukset palautetuilta versiolta',
11381138 'revdelete-log' => 'Syy',
11391139 'revdelete-submit' => 'Toteuta {{PLURAL:$1|valittuun versioon|valittuihin versioihin}}',
1140 -'revdelete-logentry' => 'muutti sivun [[$1]] version näkyvyyttä',
1141 -'logdelete-logentry' => 'muutti sivun [[$1]] näkyvyyttä',
11421140 'revdelete-success' => "'''Version näkyvyys päivitetty.'''",
11431141 'revdelete-failure' => "'''Version näkyvyyttä ei voitu päivittää:'''
11441142 $1",
@@ -1149,15 +1147,6 @@
11501148 'revdel-restore-visible' => 'näkyvät muutokset',
11511149 'pagehist' => 'Sivun muutoshistoria',
11521150 'deletedhist' => 'Poistettujen versioiden historia',
1153 -'revdelete-content' => 'sisällön',
1154 -'revdelete-summary' => 'yhteenvedon',
1155 -'revdelete-uname' => 'käyttäjänimen',
1156 -'revdelete-restricted' => 'asetti rajoitukset ylläpitäjille',
1157 -'revdelete-unrestricted' => 'poisti rajoitukset ylläpitäjiltä',
1158 -'revdelete-hid' => 'piilotti $1',
1159 -'revdelete-unhid' => 'palautti näkyviin $1',
1160 -'revdelete-log-message' => '$1 koskien $2 {{PLURAL:$2|versiota}}',
1161 -'logdelete-log-message' => '$1 koskien $2 {{PLURAL:$2|tapahtumaa}}',
11621151 'revdelete-hide-current' => 'Virhe tapahtui $2, $1 päivätyn kohteen piilottamisessa: tämä on nykyinen versio. Sitä ei voi piilottaa.',
11631152 'revdelete-show-no-access' => 'Virhe näyttäessä kohtaa $2 kello $1: kohta on merkitty ”rajoitetuksi”.
11641153 Sinulla ei ole oikeutta siihen.',
@@ -2226,8 +2215,6 @@
22272216 'actionfailed' => 'Toiminto epäonnistui',
22282217 'deletedtext' => '”$1” on poistettu.
22292218 Sivulla $2 on lista viimeaikaisista poistoista.',
2230 -'deletedarticle' => 'poisti sivun [[$1]]',
2231 -'suppressedarticle' => 'häivytti sivun [[$1]]',
22322219 'dellogpage' => 'Poistoloki',
22332220 'dellogpagetext' => 'Alla on loki viimeisimmistä poistoista.',
22342221 'deletionlog' => 'poistoloki',
@@ -2342,7 +2329,6 @@
23432330 'undeletereset' => 'Tyhjennä',
23442331 'undeleteinvert' => 'Käänteinen valinta',
23452332 'undeletecomment' => 'Syy',
2346 -'undeletedarticle' => 'palautti sivun [[$1]]',
23472333 'undeletedrevisions' => '{{PLURAL:$1|Yksi versio|$1 versiota}} palautettiin',
23482334 'undeletedrevisions-files' => '{{PLURAL:$1|Yksi versio|$1 versiota}} ja {{PLURAL:$2|yksi tiedosto|$2 tiedostoa}} palautettiin',
23492335 'undeletedfiles' => '{{PLURAL:$1|1 tiedosto|$1 tiedostoa}} palautettiin',
@@ -3671,4 +3657,20 @@
36723658 'sqlite-has-fts' => '$1, jossa on tuki kokotekstihaulle',
36733659 'sqlite-no-fts' => '$1, jossa ei ole tukea kokotekstihaulle',
36743660
 3661+# New logging system
 3662+'logentry-delete-delete' => '$1 poisti sivun $3',
 3663+'logentry-delete-restore' => '$1 palautti sivun $3',
 3664+'logentry-delete-event' => '$1 muutti {{PLURAL:$5||$5}} lokitapahtuman näkyvyyttä $3: $4',
 3665+'logentry-delete-revision' => '$1 muutti {{PLURAL:$5||$5}} muutoksen näkyvyyttä sivulla $3: $4',
 3666+'logentry-delete-event-legacy' => '$1 muutti lokitapahtumien näkyvyyttä $3',
 3667+'logentry-delete-revision-legacy' => '$1 muutti sivun $3 muutosten näkyvyyttä',
 3668+'revdelete-content-hid' => 'sisältö piilotettu',
 3669+'revdelete-summary-hid' => 'muokkausyhteenveto piilotettu',
 3670+'revdelete-uname-hid' => 'käyttäjätunnus piilotettu',
 3671+'revdelete-content-unhid' => 'sisältö palautettu näkyviin',
 3672+'revdelete-summary-unhid' => 'muokkausyhteenveto palautettu näkyviin',
 3673+'revdelete-uname-unhid' => 'käyttäjätunnus palautettu näkyviin',
 3674+'revdelete-restricted' => 'asetti rajoitukset ylläpitäjille',
 3675+'revdelete-unrestricted' => 'poisti rajoitukset ylläpitäjiltä',
 3676+
36753677 );

Sign-offs

UserFlagDate
Aaron Schulztested22:15, 15 September 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r97046Removed some more unused message made obsolete by r96847 (one was still refer...nikerabbit10:43, 14 September 2011
r97080Fix typo in r97044 reported in twnnikerabbit18:02, 14 September 2011
r97082Merged revisions 97057,97060,97071,97073-97074,97077-97080 via svnmerge from...dantman18:11, 14 September 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   22:15, 15 September 2011

getMessageParameters for the delete log formatter could use more documentation.

#Comment by Nikerabbit (talk | contribs)   05:56, 16 September 2011

Hah. It would have helped me a lot if the parameters of deletion and suppression logs were documented somewhere. I'll see if I can write anything comprehensible what I've learned.

Status & tagging log