r96952 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96951‎ | r96952 | r96953 >
Date:11:03, 13 September 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18 MFT r96950
Modified paths:
  • /branches/REL1_18/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/db/Database.php
@@ -1712,9 +1712,6 @@
17131713 } elseif ( $value === null ) {
17141714 if ( $mode == LIST_AND || $mode == LIST_OR ) {
17151715 $list .= "$field IS ";
1716 - if ( $not ) {
1717 - $list .= "NOT ";
1718 - }
17191716 } elseif ( $mode == LIST_SET ) {
17201717 $list .= "$field = ";
17211718 }
@@ -2840,8 +2837,8 @@
28412838 /**
28422839 * Get slave lag. Currently supported only by MySQL.
28432840 *
2844 - * Note that this function will generate a fatal error on many
2845 - * installations. Most callers should use LoadBalancer::safeGetLag()
 2841+ * Note that this function will generate a fatal error on many
 2842+ * installations. Most callers should use LoadBalancer::safeGetLag()
28462843 * instead.
28472844 *
28482845 * @return Database replication lag in seconds
Property changes on: branches/REL1_18/phase3/includes/db/Database.php
___________________________________________________________________
Modified: svn:mergeinfo
28492846 Merged /trunk/includes/db/Database.php:r96950
28502847 Merged /trunk/phase3/includes/db/Database.php:r96950

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96932REL1_18: MFT r96930reedy00:33, 13 September 2011
r96950Fix revert artefact of r96930reedy10:59, 13 September 2011

Status & tagging log