r96953 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96952‎ | r96953 | r96954 >
Date:11:10, 13 September 2011
Author:ialex
Status:ok
Tags:
Comment:
Call Linker methods statically
Modified paths:
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -196,7 +196,7 @@
197197 * @param $err String: error message or null if there's no error
198198 */
199199 function show( $err = null ) {
200 - global $wgOut, $wgUser;
 200+ global $wgOut;
201201
202202 $wgOut->setRobotPolicy( 'noindex,nofollow' );
203203
@@ -223,8 +223,7 @@
224224 $wgOut->wrapWikiMsg( "<div id=\"mw-protect-cascadeon\">\n$1\n" . $titles . "</div>", array( 'protect-cascadeon', count($cascadeSources) ) );
225225 }
226226
227 - $sk = $wgUser->getSkin();
228 - $titleLink = $sk->link( $this->mTitle );
 227+ $titleLink = Linker::link( $this->mTitle );
229228 $wgOut->setPageTitle( wfMsg( 'protect-title', $this->mTitle->getPrefixedText() ) );
230229 $wgOut->setSubtitle( wfMsg( 'protect-backlink', $titleLink ) );
231230
@@ -501,7 +500,7 @@
502501
503502 if ( $wgUser->isAllowed( 'editinterface' ) ) {
504503 $title = Title::makeTitle( NS_MEDIAWIKI, 'Protect-dropdown' );
505 - $link = $wgUser->getSkin()->link(
 504+ $link = Linker::link(
506505 $title,
507506 wfMsgHtml( 'protect-edit-reasonlist' ),
508507 array(),

Status & tagging log