r96950 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96949‎ | r96950 | r96951 >
Date:10:59, 13 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix revert artefact of r96930
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
@@ -1754,9 +1754,6 @@
17551755 } elseif ( $value === null ) {
17561756 if ( $mode == LIST_AND || $mode == LIST_OR ) {
17571757 $list .= "$field IS ";
1758 - if ( $not ) {
1759 - $list .= "NOT ";
1760 - }
17611758 } elseif ( $mode == LIST_SET ) {
17621759 $list .= "$field = ";
17631760 }
@@ -2966,8 +2963,8 @@
29672964 /**
29682965 * Get slave lag. Currently supported only by MySQL.
29692966 *
2970 - * Note that this function will generate a fatal error on many
2971 - * installations. Most callers should use LoadBalancer::safeGetLag()
 2967+ * Note that this function will generate a fatal error on many
 2968+ * installations. Most callers should use LoadBalancer::safeGetLag()
29722969 * instead.
29732970 *
29742971 * @return Database replication lag in seconds

Follow-up revisions

RevisionCommit summaryAuthorDate
r96952REL1_18 MFT r96950reedy11:03, 13 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96930Revert r87992 and followups r87998, r89028 (Support abstraction for 'NOT IN' ...demon00:19, 13 September 2011

Status & tagging log